mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 19:18:11 +00:00
Jon Ross-Perkins
937caaecce
Right now, a lot of tests have started setting `--no-dump-sem-ir`. My thought is that we can look at: 1. Put ranges in a bunch more files. 2. Shift more towards `--dump-sem-ir-ranges=only` instead of `--no-dump-sem-ir`, because it allows mixing fail-tests with no IR alongside tests that contain IR. 3. Evaluate switching the default to `--dump-sem-ir-ranges=only`, and instead set `--dump-sem-ir-ranges=if-present` only in files that want to typically show all IR (particularly import-related tests, where ranges don't work well). In real-world use, my thought is also that it'd be helpful to be able to add the dump range comments to files, see the output (i.e., the default behavior of `if-present`) but then also be able to pass `ignore` in order to see the full IR without modifying the file (possibly also useful in tests). That model is why I went for tri-state handling. Note `only` can also have an interesting side-effect. Because core files (including min_prelude versions) typically won't have ranges, they'd be implicitly excluded.