mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 13:31:06 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
52 lines
2.1 KiB
C++
52 lines
2.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_BASE_CANONICAL_VALUE_STORE_IMPL_H_
|
|
#define CARBON_TOOLCHAIN_BASE_CANONICAL_VALUE_STORE_IMPL_H_
|
|
|
|
#include "toolchain/base/canonical_value_store.h"
|
|
|
|
namespace Carbon {
|
|
|
|
template <typename IdT, typename KeyT, typename TagIdT, typename ValueT>
|
|
CanonicalValueStore<IdT, KeyT, TagIdT, ValueT>::CanonicalValueStore()
|
|
requires(IdTagIsUntagged<IdTag<IdT, TagIdT>>)
|
|
= default;
|
|
|
|
template <typename IdT, typename KeyT, typename TagIdT, typename ValueT>
|
|
CanonicalValueStore<IdT, KeyT, TagIdT, ValueT>::CanonicalValueStore(
|
|
typename IdTagType::TagIdType id, int32_t initial_reserved_ids)
|
|
requires(!IdTagIsUntagged<IdTag<IdT, TagIdT>>)
|
|
: values_(id, initial_reserved_ids) {}
|
|
|
|
template <typename IdT, typename KeyT, typename TagIdT, typename ValueT>
|
|
CanonicalValueStore<IdT, KeyT, TagIdT, ValueT>::~CanonicalValueStore() =
|
|
default;
|
|
|
|
template <typename IdT, typename KeyT, typename TagIdT, typename ValueT>
|
|
CanonicalValueStore<IdT, KeyT, TagIdT, ValueT>::CanonicalValueStore(
|
|
CanonicalValueStore&&) noexcept = default;
|
|
|
|
template <typename IdT, typename KeyT, typename TagIdT, typename ValueT>
|
|
auto CanonicalValueStore<IdT, KeyT, TagIdT, ValueT>::operator=(
|
|
CanonicalValueStore&&) noexcept -> CanonicalValueStore& = default;
|
|
|
|
template <typename IdT, typename KeyT, typename TagIdT, typename ValueT>
|
|
auto CanonicalValueStore<IdT, KeyT, TagIdT, ValueT>::OutputYaml() const
|
|
-> Yaml::OutputMapping {
|
|
return values_.OutputYaml();
|
|
}
|
|
|
|
template <typename IdT, typename KeyT, typename TagIdT, typename ValueT>
|
|
auto CanonicalValueStore<IdT, KeyT, TagIdT, ValueT>::CollectMemUsage(
|
|
MemUsage& mem_usage, llvm::StringRef label) const -> void {
|
|
mem_usage.Collect(MemUsage::ConcatLabel(label, "values_"), values_);
|
|
auto bytes = set_.ComputeMetrics(KeyContext(&values_)).storage_bytes;
|
|
mem_usage.Add(MemUsage::ConcatLabel(label, "set_"), bytes, bytes);
|
|
}
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_BASE_CANONICAL_VALUE_STORE_IMPL_H_
|