carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 22:02:23 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
1dbf000905f2b2ff80f8ea51c1930c6d896fcf61
carbon-lang/toolchain/check
T
History
Dana Jansens 64139e5d65 Stop using Map for the cache in InstFingerprinter (#6019) 
This takes the debug runtime of
`toolchain/check/testdata/interop/cpp/function/arithmetic_types_bridged.carbon`
from 4.7s down to about 4s (so 15% faster overall).

There's still lots of room to improve this test which seems to be
hitting lots of pathological behaviour, but InstNamer is 30% of the
runtime, with fingerprinting's `InstFingerprinter::GetOrCompute`
consuming 10% of cycles. We reduce its impact by using a vector of
vectors instead of a Map for the cache of fingerprints. After this
change InstNamer drops below 24% of the runtime.

Also move the instruction name when giving it to `AllocateName` since it
receives std::string by value, though this doesn't show up in the
profile for the test.
2025-09-08 16:15:10 +00:00
..
fuzzer_corpus
Change array syntax from [T; N] to array(T, N) (#4981)
2025-02-20 22:42:47 +00:00
testdata
C++ interop: Support unary operators (#6020)
2025-09-08 15:39:08 +00:00
action.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
action.h
Even more usage of TypeInstId (#5296)
2025-04-11 21:47:43 +00:00
BUILD
Interop: map C++ std::string_view into Carbon str when importing. (#5985)
2025-08-27 01:02:39 +00:00
call.cpp
Fix double-destruction of temporaries. (#6010)
2025-09-04 19:19:59 +00:00
call.h
Use As and ImplicitAs interfaces for conversions. (#4209)
2024-09-05 23:39:58 +00:00
check_fuzzer.cpp
Switch Driver back to parameters for construction (#4849)
2025-01-27 23:48:44 +00:00
check_unit.cpp
Stop using Map for the cache in InstFingerprinter (#6019)
2025-09-08 16:15:10 +00:00
check_unit.h
Stop using Map for the cache in InstFingerprinter (#6019)
2025-09-08 16:15:10 +00:00
check.cpp
Stop using Map for the cache in InstFingerprinter (#6019)
2025-09-08 16:15:10 +00:00
check.h
Stop using Map for the cache in InstFingerprinter (#6019)
2025-09-08 16:15:10 +00:00
class.cpp
Add a vtableDecl inst and use that in classes instead of VtablePtr (#5945)
2025-08-15 18:36:54 +00:00
class.h
Vtable support for generics (#5793)
2025-07-11 22:29:10 +00:00
context.cpp
Stop using Map for the cache in InstFingerprinter (#6019)
2025-09-08 16:15:10 +00:00
context.h
Stop using Map for the cache in InstFingerprinter (#6019)
2025-09-08 16:15:10 +00:00
control_flow.cpp
Tag destruction as desugaring (#5790)
2025-07-10 21:21:19 +00:00
control_flow.h
Handle destruction for return statements (#5785)
2025-07-10 16:32:39 +00:00
convert.cpp
Fix double-destruction of temporaries. (#6010)
2025-09-04 19:19:59 +00:00
convert.h
Add support for unsafe as operator to the toolchain. (#5993)
2025-08-28 23:00:53 +00:00
cpp_custom_type_mapping.cpp
Interop: map C++ std::string_view into Carbon str when importing. (#5985)
2025-08-27 01:02:39 +00:00
cpp_custom_type_mapping.h
Interop: map C++ std::string_view into Carbon str when importing. (#5985)
2025-08-27 01:02:39 +00:00
cpp_thunk.cpp
Update LLVM (#6022)
2025-09-06 08:36:10 +00:00
cpp_thunk.h
Generate and use a C++ thunk to call non simple ABI C++ functions (#5850)
2025-08-06 10:27:33 +00:00
decl_introducer_state.h
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
decl_name_stack.cpp
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
decl_name_stack.h
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
deduce.cpp
Avoid deducing errors as argument instructions after subst (#5710)
2025-06-23 23:10:33 +00:00
deduce.h
Fearlessly hold references into ValueStore again (#5589)
2025-06-03 18:07:23 +00:00
deferred_definition_worklist.cpp
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
deferred_definition_worklist.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
diagnostic_emitter.cpp
Switch to representing FloatLiteralType as a RealId. (#5944)
2025-08-12 22:08:07 +00:00
diagnostic_emitter.h
Expand use of CheckIRId stores (#5820)
2025-07-21 20:02:27 +00:00
diagnostic_helpers.h
Move TokenOnly to LocIdForDiagnostics (#5590)
2025-06-03 01:14:54 +00:00
dump.cpp
Move LocId dumping to semir/ (#5656)
2025-06-12 20:37:27 +00:00
eval_inst.cpp
Add support for f16, f64, f128. (#5952)
2025-08-14 01:14:40 +00:00
eval_inst.h
Support for lowering references to imported vars. (#5513)
2025-05-29 19:48:16 +00:00
eval.cpp
Add MaybeUnformed(T) type. (#5989)
2025-09-02 20:50:49 +00:00
eval.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
facet_type.cpp
Remove todo in facet_type.cpp after exploration (#5950)
2025-08-13 16:01:31 +00:00
facet_type.h
Add the .Self name for the type expression of a compile time binding (#5937)
2025-08-12 16:27:07 +00:00
full_pattern_stack.h
Clean up handling of Call params (#5061)
2025-03-04 21:01:59 +00:00
function.cpp
Make use of new ArrayRef::consume_* functions. (#5975)
2025-08-21 21:41:53 +00:00
function.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
generic_region_stack.cpp
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
generic_region_stack.h
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
generic.cpp
Find cycles in rewrite constraints without performing the full exponential expansion of the RHS (#5673)
2025-07-29 16:31:28 +00:00
generic.h
Avoid resolving the decl block for specifics in imported instructions (#5517)
2025-05-23 16:58:46 +00:00
global_init.cpp
[Refactor] Move call_params_id from EntityBase to FunctionFields. (#5146)
2025-03-18 23:49:24 +00:00
global_init.h
Split global init out from InstBlockStack. (#4101)
2024-07-03 17:49:47 +00:00
handle_alias.cpp
Stop pushing a fake generic for the duration of check. (#5326)
2025-04-17 21:58:37 +00:00
handle_array.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_binding_pattern.cpp
Decouple associated constants from let (#5973)
2025-09-02 23:15:26 +00:00
handle_call_expr.cpp
Include the call arguments in the location of a call. (#4602)
2024-12-02 18:51:44 +00:00
handle_choice.cpp
Fearlessly hold references into ValueStore again (#5589)
2025-06-03 18:07:23 +00:00
handle_class.cpp
Generate Destroy impls for classes (#5873)
2025-08-04 19:39:22 +00:00
handle_codeblock.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_export.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_expr_statement.cpp
Convert discarded calls in thunks. (#5452)
2025-05-09 16:35:28 +00:00
handle_file.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_function.cpp
Make use of new ArrayRef::consume_* functions. (#5975)
2025-08-21 21:41:53 +00:00
handle_if_expr.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_if_statement.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_impl.cpp
Factor out an impl declaration helper function (#5851)
2025-07-25 18:34:07 +00:00
handle_import_and_package.cpp
Support import Cpp inline "some code";. (#5904)
2025-08-05 23:03:32 +00:00
handle_index.cpp
Make pointers in ValueStore stable across insertions (#5576)
2025-06-02 19:16:31 +00:00
handle_interface.cpp
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
handle_let_and_var.cpp
Decouple associated constants from let (#5973)
2025-09-02 23:15:26 +00:00
handle_literal.cpp
Add basic support for strings to core, check, and lower. (#5963)
2025-08-20 00:18:50 +00:00
handle_loop_statement.cpp
Check and lowering support for for loops. (#5698)
2025-06-25 23:45:14 +00:00
handle_match.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_modifier.cpp
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
handle_name.cpp
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
handle_named_constraint.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_namespace.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
handle_noop.cpp
Abort checking when encountering an invalid parse node (#4700)
2024-12-18 00:19:12 +00:00
handle_operator.cpp
Add support for unsafe as operator to the toolchain. (#5993)
2025-08-28 23:00:53 +00:00
handle_paren_expr.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_pattern_list.cpp
Decouple associated constants from let (#5973)
2025-09-02 23:15:26 +00:00
handle_return_statement.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_struct.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_tuple_literal.cpp
Remove all remaining uses of TypeIds as instruction operands. (#5280)
2025-04-10 20:53:42 +00:00
handle_where.cpp
Add the .Self name for the type expression of a compile time binding (#5937)
2025-08-12 16:27:07 +00:00
handle.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
impl_lookup.cpp
Verify rewrite constraints in impl lookup (#5617)
2025-08-01 18:04:20 +00:00
impl_lookup.h
Diagnose impls that are fully overlapped by a final impl (#5417)
2025-05-10 17:36:28 +00:00
impl_validation.cpp
Switch handling of errors in impls to not build a type structure (#5881)
2025-07-30 20:24:38 +00:00
impl_validation.h
Add diagnostics for invalid impl declarations (#5420)
2025-05-22 18:58:47 +00:00
impl.cpp
Factor out an impl declaration helper function (#5851)
2025-07-25 18:34:07 +00:00
impl.h
Factor out an impl declaration helper function (#5851)
2025-07-25 18:34:07 +00:00
implicit_type_impls.cpp
Fix destruction of generic types (#5943)
2025-08-12 00:10:43 +00:00
implicit_type_impls.h
Generate Destroy impls for classes (#5873)
2025-08-04 19:39:22 +00:00
import_cpp.cpp
C++ interop: Support unary operators (#6020)
2025-09-08 15:39:08 +00:00
import_cpp.h
C++ interop: Support importing binary operator+ (#5996)
2025-09-03 12:01:20 +00:00
import_ref.cpp
Always import canonical instructions except for exceptional Decl cases (#6009)
2025-09-03 22:36:27 +00:00
import_ref.h
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
import.cpp
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
import.h
Initial support for interop with class/struct/union fields. (#5849)
2025-07-25 21:09:24 +00:00
inst_block_stack.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
inst_block_stack.h
Split SemIR's formatter class into a more typical h+cpp (#5372)
2025-04-29 18:00:07 +00:00
inst.cpp
Change from ToImplicit to AsDesugared (#5591)
2025-06-03 17:55:16 +00:00
inst.h
Fix a small implicit/desugared reference (#5791)
2025-07-10 18:27:28 +00:00
interface.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
interface.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
keyword_modifier_set.h
Clean up KeywordModifierSet after #5345 (#5425)
2025-05-06 16:56:06 +00:00
lexical_lookup.h
Set an explicit size for lexical lookup's vector (#5786)
2025-07-09 22:42:27 +00:00
literal.cpp
C++ Interop: Add support for char (#5988)
2025-08-29 01:11:24 +00:00
literal.h
C++ Interop: Add support for char (#5988)
2025-08-29 01:11:24 +00:00
member_access.cpp
Compare ImplWitnessAccess into Self as canonical constants (#5883)
2025-08-08 18:36:39 +00:00
member_access.h
Build generic eval blocks incrementally (#5313)
2025-05-01 20:24:15 +00:00
merge.cpp
Support importing var parameters (#5400)
2025-05-19 22:50:16 +00:00
merge.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
modifiers.cpp
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
modifiers.h
Refactor modifier formatting to remove string passing. (#4418)
2024-10-17 22:47:40 +00:00
name_component.cpp
Fix parse support for 'fn F[];' (#5135)
2025-03-18 00:31:17 +00:00
name_component.h
Id::Invalid -> Id::None (#4834)
2025-01-22 23:15:00 +00:00
name_lookup.cpp
Add support for importing access from C++ to Carbon (#5858)
2025-07-29 08:25:15 +00:00
name_lookup.h
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
name_ref.cpp
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
name_ref.h
Fix lowering of thunks in generic impls (#5631)
2025-06-10 20:54:58 +00:00
node_id_traversal.cpp
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
node_id_traversal.h
Track pending thunks on the deferred definition worklist. (#5609)
2025-06-10 22:09:31 +00:00
node_stack.cpp
Avoid redundantly specifying Id::Kind. (#4911)
2025-02-07 22:35:18 +00:00
node_stack.h
Decouple associated constants from let (#5973)
2025-09-02 23:15:26 +00:00
operator.cpp
C++ interop: Support unary operators (#6020)
2025-09-08 15:39:08 +00:00
operator.h
Move diagnostic usings off Context (#5007)
2025-02-26 18:44:36 +00:00
param_and_arg_refs_stack.h
Consolidate post-check logic (#5003)
2025-02-25 02:07:43 +00:00
pattern_match.cpp
Fix double-destruction of temporaries. (#6010)
2025-09-04 19:19:59 +00:00
pattern_match.h
Invalid comment cleanup (#4836)
2025-01-23 02:21:48 +00:00
pattern.cpp
Generate Destroy impls for classes (#5873)
2025-08-04 19:39:22 +00:00
pattern.h
Generate Destroy impls for classes (#5873)
2025-08-04 19:39:22 +00:00
pending_block.h
Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
2025-04-28 19:06:24 +00:00
pointer_dereference.cpp
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
pointer_dereference.h
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
region_stack.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
return.cpp
Handle destruction for return statements (#5785)
2025-07-10 16:32:39 +00:00
return.h
Generate thunks for functions in impls (#5390)
2025-05-01 22:17:55 +00:00
scope_index.h
Move None to IdBase (#5030)
2025-03-01 08:00:17 +00:00
scope_stack.cpp
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
scope_stack.h
Defer building thunks until the end of the enclosing definition. (#5403)
2025-05-07 22:20:39 +00:00
subst.cpp
Resolve nested accesses in rewrite constraints (#5872)
2025-07-30 14:34:24 +00:00
subst.h
Resolve nested accesses in rewrite constraints (#5872)
2025-07-30 14:34:24 +00:00
thunk.cpp
When making a direct call to a thunk, inline the call in SemIR. (#5642)
2025-06-11 21:34:01 +00:00
thunk.h
When making a direct call to a thunk, inline the call in SemIR. (#5642)
2025-06-11 21:34:01 +00:00
type_completion.cpp
Add MaybeUnformed(T) type. (#5989)
2025-09-02 20:50:49 +00:00
type_completion.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
type_structure.cpp
Switch handling of errors in impls to not build a type structure (#5881)
2025-07-30 20:24:38 +00:00
type_structure.h
Switch handling of errors in impls to not build a type structure (#5881)
2025-07-30 20:24:38 +00:00
type.cpp
Improve support for qualification conversions. (#5999)
2025-09-03 21:00:12 +00:00
type.h
Support conversion from T* to const T*. (#5971)
2025-08-20 23:27:03 +00:00