mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 21:25:54 +01:00
Jon Ross-PerkinsandChandler Carruth
0c0998d7cd
This gets to a lifetime subtlety, particularly with things like the
sorting diagnostic consumer that delay output. In order to reduce the
chance of accidental references, disallow StringRef in the diagnostics.
For example:
```
./toolchain/diagnostics/diagnostic_emitter.h:162:5: error: static_assert failed due to requirement '!std::is_same_v<llvm::StringRef, llvm::StringRef>' "Use std::string or llvm::StringLiteral for diagnostic lifetimes."
static_assert(
^
toolchain/check/convert.cpp:477:11: note: in instantiation of member function 'Carbon::Internal::DiagnosticBase<std::string, std::string, llvm::StringRef>::DiagnosticBase' requested here
CARBON_DIAGNOSTIC(StructInitMissingFieldInConversion, Error,
^
./toolchain/diagnostics/diagnostic_emitter.h:47:7: note: expanded from macro 'CARBON_DIAGNOSTIC'
::Carbon::Internal::DiagnosticBase<__VA_ARGS__>( \
^
```
---------
Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
65 lines
2.4 KiB
C++
65 lines
2.4 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/parse/context.h"
|
|
|
|
namespace Carbon::Parse {
|
|
|
|
// Handles PeriodAs variants and ArrowExpr.
|
|
// TODO: This currently only supports identifiers on the rhs, but will in the
|
|
// future need to handle things like `object.(Interface.member)` for qualifiers.
|
|
static auto HandlePeriodOrArrow(Context& context, NodeKind node_kind,
|
|
bool is_arrow) -> void {
|
|
auto state = context.PopState();
|
|
|
|
// `.` identifier
|
|
auto dot = context.ConsumeChecked(is_arrow ? Lex::TokenKind::MinusGreater
|
|
: Lex::TokenKind::Period);
|
|
|
|
if (!context.ConsumeAndAddLeafNodeIf(Lex::TokenKind::Identifier,
|
|
NodeKind::Name)) {
|
|
CARBON_DIAGNOSTIC(ExpectedIdentifierAfterDotOrArrow, Error,
|
|
"Expected identifier after `{0}`.", llvm::StringLiteral);
|
|
context.emitter().Emit(
|
|
*context.position(), ExpectedIdentifierAfterDotOrArrow,
|
|
is_arrow ? llvm::StringLiteral("->") : llvm::StringLiteral("."));
|
|
// If we see a keyword, assume it was intended to be a name.
|
|
// TODO: Should keywords be valid here?
|
|
if (context.PositionKind().is_keyword()) {
|
|
context.AddLeafNode(NodeKind::Name, context.Consume(),
|
|
/*has_error=*/true);
|
|
} else {
|
|
context.AddLeafNode(NodeKind::Name, *context.position(),
|
|
/*has_error=*/true);
|
|
// Indicate the error to the parent state so that it can avoid producing
|
|
// more errors.
|
|
context.ReturnErrorOnState();
|
|
}
|
|
}
|
|
|
|
context.AddNode(node_kind, dot, state.subtree_start, state.has_error);
|
|
}
|
|
|
|
auto HandlePeriodAsDecl(Context& context) -> void {
|
|
HandlePeriodOrArrow(context, NodeKind::QualifiedDecl,
|
|
/*is_arrow=*/false);
|
|
}
|
|
|
|
auto HandlePeriodAsExpr(Context& context) -> void {
|
|
HandlePeriodOrArrow(context, NodeKind::MemberAccessExpr,
|
|
/*is_arrow=*/false);
|
|
}
|
|
|
|
auto HandlePeriodAsStruct(Context& context) -> void {
|
|
HandlePeriodOrArrow(context, NodeKind::StructFieldDesignator,
|
|
/*is_arrow=*/false);
|
|
}
|
|
|
|
auto HandleArrowExpr(Context& context) -> void {
|
|
HandlePeriodOrArrow(context, NodeKind::PointerMemberAccessExpr,
|
|
/*is_arrow=*/true);
|
|
}
|
|
|
|
} // namespace Carbon::Parse
|