Chandler CarruthandChristopher Di Bella 14a213d095 Apply the unused-without-definition check to implicit parameters (#7270) ...

The `unused` modifier is rejected on parameters of a function
declaration, but the check only covered the explicit parameter list, so
an implicit parameter (such as self or a compile-time binding) could
carry unused without a definition. Check the implicit parameter list
too.

The code changes and the test updates are split into two commits for
easier review.

Assisted-by: Claude Code with Claude Opus 4.7

---------

Co-authored-by: Christopher Di Bella <cjdb.ns@gmail.com>

2026-05-30 08:26:09 +00:00

..

custom_witness

Avoid crashing in custom witness for FacetTypes and symbolic object representations (#7033)

2026-04-08 20:09:03 +00:00

lookup

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

assoc_const_self.carbon

Only propagate .Self dependence in facet types from extended constraints (#7253)

2026-05-27 22:04:48 +00:00

basic.carbon

Apply the unused-without-definition check to implicit parameters (#7270)

2026-05-30 08:26:09 +00:00

compound.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

declaration.carbon

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

empty.carbon

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

error_recovery.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

eval_musteval.carbon

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

extend_final.carbon

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

extend_impl_generic.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

extend_impl.carbon

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

fail_alias.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_call_invalid.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_extend_impl_forall.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_extend_impl_scope.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_extend_impl_type_as.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_extend_non_interface.carbon

Resolve cycles in .Self replacement in nested designators (#7183)

2026-05-13 16:11:20 +00:00

fail_extend_partially_defined_interface.carbon

Format the InterfaceWithSelf and NamedConstraintWithSelf generic name with its ".WithSelf" suffix (#6798)

2026-02-27 13:50:56 +00:00

fail_extend_undefined_interface.carbon

Reverse nesting structure of parameter patterns (#6930)

2026-03-23 20:38:20 +00:00

fail_impl_as_scope.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_impl_bad_assoc_const.carbon

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

fail_impl_bad_assoc_fn.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_impl_bad_interface.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_impl_bad_type.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_redefinition.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_self_type_mismatch.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

fail_todo_form_thunk.carbon

Replace form insts with actions (#7100)

2026-04-29 18:13:42 +00:00

forward_decls.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

generic_redeclaration.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

impl_as_named_constraint.carbon

Add tests that demonstrate missing diagnostics for impl as a named constraint (#7195)

2026-05-12 22:15:09 +00:00

impl_as.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

impl_assoc_const_with_prelude.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

impl_assoc_const.carbon

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

impl_forall.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

impl_inside_interface.carbon

Detect impl redecls in non-declarative scopes (#7170)

2026-05-07 13:44:40 +00:00

impl_self_as.carbon

Introduce the none.carbon min-prelude (#5694)

2025-06-18 20:45:46 +00:00

impl_thunk_min_prelude.carbon

Don't convert runtime arguments during deduction. (#7265)

2026-05-27 21:44:29 +00:00

impl_thunk.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

impl_where_redecl.carbon

Introduce the none.carbon min-prelude (#5694)

2025-06-18 20:45:46 +00:00

import_builtin_call.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import_canonical_witnesses.carbon

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

import_compound.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import_extend_impl.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import_generic.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import_impl_with_no_interface.carbon

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

import_interface_assoc_const.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import_self_specific.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import_self.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import_thunk.carbon

Don't convert runtime arguments during deduction. (#7265)

2026-05-27 21:44:29 +00:00

import_use_generic.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

incomplete.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

interface_args.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

multiple_extend.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

name_lookup_in_impl_definition.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

name_poisoning.carbon

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

no_definition_in_impl_file.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

orphan.carbon

Check the orphan rule for impls (#6488)

2025-12-11 19:44:39 +00:00

redeclaration.carbon

Make proposal filenames use 6 digits and include the title (#7245)

2026-05-29 00:55:04 +00:00

reenter_scopes.carbon

Do not treat impls in different scopes as redeclarations (#7161)

2026-05-04 19:11:51 +00:00

require_satisified_in_interface.carbon

Add tests that demonstrate missing diagnostics for impl as a named constraint (#7195)

2026-05-12 22:15:09 +00:00

require_satisified_in_named_constraint.carbon

Add tests that demonstrate missing diagnostics for impl as a named constraint (#7195)

2026-05-12 22:15:09 +00:00

self_in_class.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

self_in_signature.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

todo_impl_with_unrelated_fn.carbon

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

use_assoc_entity.carbon

Apply the unused-without-definition check to implicit parameters (#7270)

2026-05-30 08:26:09 +00:00

using_invalid_interface.carbon

Include the type in the location of binding insts (#6963)

2026-03-26 18:43:29 +00:00