mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Chandler CarruthandJon Ross-Perkins
13de9e9d06
Recent runs of `clang-tidy` for me started showing more errors, and this is a collection of changes to address them. First, I've systematically applied the disabling tag to all C++ rules under //explorer/... with `buildozer` so we don't spend time analyzing this code or reporting errors from it. Not sure this was strictly necessary, but it seemed like a nice consistency improvement. Next, I disabled a buggy check for missing `default` cases in `switch`es. It seems to get confused by the fancy conversions in our `enum_base.h`. We don't miss much with this as the Clang compiler warnings for `switch` catch most of our actual bugs. I also removed the local disabling of this now that it is turned off centrally. Lastly, I added error checking to two file descriptor manipulating calls in the `file_test` infrastructure. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
64 lines
2.3 KiB
C++
64 lines
2.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "common/check.h"
|
|
#include "toolchain/base/pretty_stack_trace_function.h"
|
|
#include "toolchain/parse/context.h"
|
|
#include "toolchain/parse/node_kind.h"
|
|
#include "toolchain/parse/typed_nodes.h"
|
|
|
|
namespace Carbon::Parse {
|
|
|
|
// Declare handlers for each parse state.
|
|
#define CARBON_PARSE_STATE(Name) auto Handle##Name(Context& context) -> void;
|
|
#include "toolchain/parse/state.def"
|
|
|
|
auto HandleInvalid(Context& context) -> void {
|
|
CARBON_FATAL() << "The Invalid state shouldn't be on the stack: "
|
|
<< context.PopState();
|
|
}
|
|
|
|
auto Parse(Lex::TokenizedBuffer& tokens, DiagnosticConsumer& consumer,
|
|
llvm::raw_ostream* vlog_stream) -> Tree {
|
|
Lex::TokenLocationTranslator translator(&tokens);
|
|
Lex::TokenDiagnosticEmitter emitter(translator, consumer);
|
|
|
|
// Delegate to the parser.
|
|
Tree tree(tokens);
|
|
Context context(tree, tokens, emitter, vlog_stream);
|
|
PrettyStackTraceFunction context_dumper(
|
|
[&](llvm::raw_ostream& output) { context.PrintForStackDump(output); });
|
|
|
|
context.AddLeafNode(NodeKind::FileStart,
|
|
context.ConsumeChecked(Lex::TokenKind::FileStart));
|
|
|
|
context.PushState(State::DeclScopeLoop);
|
|
|
|
while (!context.state_stack().empty()) {
|
|
switch (context.state_stack().back().state) {
|
|
#define CARBON_PARSE_STATE(Name) \
|
|
case State::Name: \
|
|
Handle##Name(context); \
|
|
break;
|
|
#include "toolchain/parse/state.def"
|
|
}
|
|
}
|
|
|
|
context.AddLeafNode(NodeKind::FileEnd, *context.position());
|
|
|
|
if (auto verify = tree.Verify(); !verify.ok()) {
|
|
// TODO: This is temporarily printing to stderr directly during development.
|
|
// If we can, restrict this to a subtree with the error and add it to the
|
|
// stack trace (such as with PrettyStackTraceFunction). Otherwise, switch
|
|
// back to vlog_stream prior to broader distribution so that end users are
|
|
// hopefully comfortable copy-pasting stderr when there are bugs in tree
|
|
// construction.
|
|
tree.Print(llvm::errs());
|
|
CARBON_FATAL() << "Invalid tree returned by Parse(): " << verify.error();
|
|
}
|
|
return tree;
|
|
}
|
|
|
|
} // namespace Carbon::Parse
|