mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
42 lines
1.5 KiB
C++
42 lines
1.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/parse/context.h"
|
|
#include "toolchain/parse/handle.h"
|
|
|
|
namespace Carbon::Parse {
|
|
|
|
// Handles a `base` declaration after the introducer.
|
|
auto HandleBaseAfterIntroducer(Context& context) -> void {
|
|
auto state = context.PopState();
|
|
|
|
if (!context.ConsumeAndAddLeafNodeIf(Lex::TokenKind::Colon,
|
|
NodeKind::BaseColon)) {
|
|
// TODO: If the next token isn't a colon or `class`, try to recover
|
|
// based on whether we're in a class, whether we have an `extend`
|
|
// modifier, and the following tokens.
|
|
CARBON_DIAGNOSTIC(ExpectedAfterBase, Error,
|
|
"`class` or `:` expected after `base`.");
|
|
context.emitter().Emit(*context.position(), ExpectedAfterBase);
|
|
context.RecoverFromDeclError(state, NodeKind::BaseDecl,
|
|
/*skip_past_likely_end=*/true);
|
|
return;
|
|
}
|
|
|
|
state.state = State::BaseDecl;
|
|
context.PushState(state);
|
|
context.PushState(State::Expr);
|
|
}
|
|
|
|
// Handles processing of a complete `base: B` declaration.
|
|
auto HandleBaseDecl(Context& context) -> void {
|
|
auto state = context.PopState();
|
|
|
|
context.AddNodeExpectingDeclSemi(state, NodeKind::BaseDecl,
|
|
Lex::TokenKind::Base,
|
|
/*is_def_allowed=*/false);
|
|
}
|
|
|
|
} // namespace Carbon::Parse
|