mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:10:13 +01:00
Lex now prints its yaml as: ``` - filename: name tokens: [ ... ] ``` New support in file_test allows the `filename` marker at the top to define the default file number for later lines, meaning multi-file output from lexing is now associated with the appropriate file. Similar support will probably also apply to lowering, semir, and other places that print a filename once for the full dump. This hammers a bit at how line number replacements work in file_test, allowing stacking them so that lex errors and stdout can both be line-associated properly. I've tried to make the autoupdate more frequently work in one pass, now also taking into account the file index when doing line replacements. There are still some issues with EndOfFile that it may be good to discuss: because CHECK lines are appended to the end of the file now, and the EndOfFile token points at the last line including comments, new lex tests now take two runs to autoupdate (because without CHECK lines, the EndOfFile points at a content line, which content is then inserted after). Note that removing CHECK lines from the test is not a solution: autoupdate also started inserting blank lines, which breaks this for a similar reason. One solution here might be to not have EndOfFile associate with a line or column, which has been a bit of an issue regardless. Also fixes a small issue with toolchain's autoupdate script.
113 lines
3.8 KiB
C++
113 lines
3.8 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "absl/flags/flag.h"
|
|
#include "explorer/main.h"
|
|
#include "re2/re2.h"
|
|
#include "testing/base/test_raw_ostream.h"
|
|
#include "testing/file_test/file_test_base.h"
|
|
|
|
ABSL_FLAG(bool, trace, false,
|
|
"Set to true to run tests with tracing enabled, even if they don't "
|
|
"otherwise specify it. This does not result in checking trace output "
|
|
"contents; it essentially only verifies there's not a crash bug.");
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
class ExplorerFileTest : public FileTestBase {
|
|
public:
|
|
explicit ExplorerFileTest(llvm::StringRef test_name)
|
|
: FileTestBase(test_name),
|
|
prelude_line_re_(R"(prelude.carbon:(\d+))"),
|
|
timing_re_(R"((Time elapsed in \w+: )\d+(ms))") {
|
|
CARBON_CHECK(prelude_line_re_.ok()) << prelude_line_re_.error();
|
|
CARBON_CHECK(timing_re_.ok()) << timing_re_.error();
|
|
}
|
|
|
|
auto Run(const llvm::SmallVector<llvm::StringRef>& test_args,
|
|
llvm::vfs::InMemoryFileSystem& fs, llvm::raw_pwrite_stream& stdout,
|
|
llvm::raw_pwrite_stream& stderr) -> ErrorOr<bool> override {
|
|
// Add the prelude.
|
|
llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> prelude =
|
|
llvm::MemoryBuffer::getFile("explorer/data/prelude.carbon");
|
|
if (prelude.getError()) {
|
|
return ErrorBuilder() << prelude.getError().message();
|
|
}
|
|
// TODO: This path is long with a prefix / because of the path expectations
|
|
// in tests. Change those to allow a shorter path (e.g., `prelude.carbon`)
|
|
// here.
|
|
static constexpr llvm::StringLiteral PreludePath =
|
|
"/explorer/data/prelude.carbon";
|
|
if (!fs.addFile(PreludePath, /*ModificationTime=*/0, std::move(*prelude))) {
|
|
return ErrorBuilder() << "Duplicate prelude.carbon";
|
|
}
|
|
|
|
llvm::SmallVector<const char*> args = {"explorer"};
|
|
for (auto arg : test_args) {
|
|
args.push_back(arg.data());
|
|
}
|
|
|
|
int exit_code = ExplorerMain(
|
|
args.size(), args.data(), /*install_path=*/"", PreludePath, stdout,
|
|
stderr, check_trace_output() ? stdout : trace_stream_, fs);
|
|
|
|
return exit_code == EXIT_SUCCESS;
|
|
}
|
|
|
|
auto ValidateRun() -> void override {
|
|
// Skip trace test check as they use stdout stream instead of
|
|
// trace_stream_ostream
|
|
if (absl::GetFlag(FLAGS_trace)) {
|
|
EXPECT_FALSE(trace_stream_.TakeStr().empty())
|
|
<< "Tracing should always do something";
|
|
}
|
|
}
|
|
|
|
auto GetDefaultArgs() -> llvm::SmallVector<std::string> override {
|
|
llvm::SmallVector<std::string> args;
|
|
if (absl::GetFlag(FLAGS_trace)) {
|
|
args.push_back("--trace_file=-");
|
|
args.push_back("--trace_phase=all");
|
|
}
|
|
args.push_back("%s");
|
|
return args;
|
|
}
|
|
|
|
auto GetLineNumberReplacements(llvm::ArrayRef<llvm::StringRef> filenames)
|
|
-> llvm::SmallVector<LineNumberReplacement> override {
|
|
if (check_trace_output()) {
|
|
return {};
|
|
}
|
|
return FileTestBase::GetLineNumberReplacements(filenames);
|
|
}
|
|
|
|
auto DoExtraCheckReplacements(std::string& check_line) -> void override {
|
|
// Ignore the resulting column of EndOfFile because it's often the end of
|
|
// the CHECK comment.
|
|
RE2::GlobalReplace(&check_line, prelude_line_re_,
|
|
R"(prelude.carbon:{{\\d+}})");
|
|
if (check_trace_output()) {
|
|
// Replace timings in trace output.
|
|
RE2::GlobalReplace(&check_line, timing_re_, R"(\1{{\\d+}}\2)");
|
|
}
|
|
}
|
|
|
|
private:
|
|
// Trace output is directly checked for a few tests.
|
|
auto check_trace_output() -> bool {
|
|
return test_name().find("/trace/") != std::string::npos;
|
|
}
|
|
|
|
TestRawOstream trace_stream_;
|
|
RE2 prelude_line_re_;
|
|
RE2 timing_re_;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
CARBON_FILE_TEST_FACTORY(ExplorerFileTest);
|
|
|
|
} // namespace Carbon::Testing
|