mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
43 lines
1.5 KiB
C++
43 lines
1.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/parse/context.h"
|
|
#include "toolchain/parse/handle.h"
|
|
|
|
namespace Carbon::Parse {
|
|
|
|
auto HandleCodeBlock(Context& context) -> void {
|
|
context.PopAndDiscardState();
|
|
|
|
context.PushState(State::CodeBlockFinish);
|
|
if (context.ConsumeAndAddLeafNodeIf(Lex::TokenKind::OpenCurlyBrace,
|
|
NodeKind::CodeBlockStart)) {
|
|
context.PushState(State::StatementScopeLoop);
|
|
} else {
|
|
context.AddLeafNode(NodeKind::CodeBlockStart, *context.position(),
|
|
/*has_error=*/true);
|
|
|
|
// Recover by parsing a single statement.
|
|
CARBON_DIAGNOSTIC(ExpectedCodeBlock, Error, "Expected braced code block.");
|
|
context.emitter().Emit(*context.position(), ExpectedCodeBlock);
|
|
|
|
context.PushState(State::Statement);
|
|
}
|
|
}
|
|
|
|
auto HandleCodeBlockFinish(Context& context) -> void {
|
|
auto state = context.PopState();
|
|
|
|
// If the block started with an open curly, this is a close curly.
|
|
if (context.tokens().GetKind(state.token) == Lex::TokenKind::OpenCurlyBrace) {
|
|
context.AddNode(NodeKind::CodeBlock, context.Consume(), state.subtree_start,
|
|
state.has_error);
|
|
} else {
|
|
context.AddNode(NodeKind::CodeBlock, state.token, state.subtree_start,
|
|
/*has_error=*/true);
|
|
}
|
|
}
|
|
|
|
} // namespace Carbon::Parse
|