mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-21 17:46:43 +00:00
Implement the toolchain side of proposal #7254, removing the `:!` binding syntax for generic and template parameters in favor of the keywords `generic`, `template`, and `runtime` plus contextual defaults for phase. For valid programs this is semantics-preserving: each binding resolves to the same phase, and produces the same SemIR, as it did under `:!`/`:`. The parser derives a binding's phase from its syntactic context plus any explicit phase keyword; new diagnostics and error recovery for misused keywords are described below. Implementation details for each component: - Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual parse-node budget onto `:`, and add the `generic` and `runtime` keywords. - Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or `CompileTimeEntityParam`) from declaration introducers down through parameter lists to each binding pattern, using a one-token lookahead to distinguish a name-qualifier parameter list from a declaration's own final list. Parameters of a compile-time entity (`class`, `interface`, `constraint`, `choice`, `alias`, `export`, `namespace`) and deduced `[]` parameters default to checked generic; explicit function parameters and local bindings default to runtime. `HandleBindingPattern` resolves the phase from that context plus the keyword: a `generic` keyword needs no node of its own (the phase is carried by the binding's node kind), while a `runtime` keyword is preserved as a `RuntimeBindingName` node so `check` can name it in a diagnostic. A phase keyword that is merely redundant with the contextual default is diagnosed here, without invalidating the parse tree. - Check: a phase keyword that is invalid for its context (for example `runtime` on a checked-generic parameter) is diagnosed here, and recovers by building an error binding that still introduces the name so that later uses of it do not produce cascading errors. The removed `:!` syntax is now rejected as an ordinary parse error. The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is left for a separate change. Assisted-by: Claude Code
129 lines
3.5 KiB
Plaintext
129 lines
3.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/lookup/find_in_final.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/lookup/find_in_final.carbon
|
|
|
|
// --- final_impl_precedence_over_facet.carbon
|
|
library "[[@TEST_NAME]]";
|
|
interface I {
|
|
let T: type;
|
|
}
|
|
|
|
final impl forall [U: type] U as I where .T = () {}
|
|
|
|
fn F(generic V: I) -> V.T {
|
|
// Even though we have a witness that `V impls I` from the constraint on `I`,
|
|
// we should do an impl lookup to see if any effectively final impl applies
|
|
// when we find an unknown value in that witness. In this case, that lookup
|
|
// would find an impl with more specific values for associated constants that
|
|
// we should merge.
|
|
return ();
|
|
}
|
|
|
|
// --- final_impl_precedence_over_facet_with_where.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {
|
|
let X: type;
|
|
let Y: type;
|
|
}
|
|
|
|
final impl forall [T: type] T as Z where .X = () and .Y = () {}
|
|
|
|
fn F(generic ZZ: Z where .X = ()) {
|
|
// Z.Y is unspecified on `ZZ` so it's found on the final impl where it's known
|
|
// to be the concrete type (), which can then be used in this generic
|
|
// function.
|
|
let unused a: ZZ.Y = ();
|
|
}
|
|
|
|
// --- final_impl_precedence_over_facet_access_type_with_where.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {
|
|
let X: type;
|
|
let Y: type;
|
|
}
|
|
|
|
final impl forall [T: type] T as Z where .X = () and .Y = () {}
|
|
|
|
fn F[T: Z where .X = ()](z: T) {
|
|
// z.Y is unspecified on `ZZ` so it's found on the final impl where it's known
|
|
// to be the concrete type (), which can then be used in this generic
|
|
// function.
|
|
let unused a: z.Y = ();
|
|
}
|
|
|
|
// --- final_impl_makes_compatible_facet_values.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I { let X: type; }
|
|
interface J {}
|
|
|
|
final impl forall [T: J] T as I where .X = () {}
|
|
|
|
class C(T: I) {
|
|
var b: T.X;
|
|
}
|
|
|
|
class D(T: J) {
|
|
var c: C(T)*;
|
|
}
|
|
|
|
fn F(generic T: I & J) -> () {
|
|
// The witness for `I` found here directly, and inside `D` from a FacetValue
|
|
// come from the same facet, the `T` binding in the params of F, so they
|
|
// should be compatible.
|
|
var x: C(T);
|
|
var y: D(T);
|
|
y.c = &x;
|
|
return (*y.c).b;
|
|
}
|
|
|
|
// --- non_final_impl_makes_compatible_facet_values.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I { let X: Core.Destroy; }
|
|
interface J {}
|
|
|
|
impl forall [T: J] T as I where .X = () {}
|
|
|
|
class C(T: I) {
|
|
var b: T.X;
|
|
}
|
|
|
|
class D(T: J) {
|
|
var c: C(T)*;
|
|
}
|
|
|
|
fn F(generic T: I & J) -> T.(I.X)* {
|
|
var x: C(T);
|
|
var y: D(T);
|
|
// The witness for `I` found here directly, and inside `D` from a FacetValue
|
|
// come from the same facet, the `T` binding in the params of F, so they
|
|
// should be compatible.
|
|
y.c = &x;
|
|
return &(*y.c).b;
|
|
}
|
|
|
|
// --- todo_fail_facet_value_rewrite_incompatible_with_final_impl.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface Z {
|
|
let X: type;
|
|
}
|
|
|
|
final impl forall [T: type] T as Z where .X = () {}
|
|
|
|
// TODO: This should be diagnosed as there is a final impl defining `.X = ()`,
|
|
// which makes the LHS of this rewrite constraint concrete. And since the RHS is
|
|
// not the same (or convertible from), the rewrite is impossible.
|
|
fn F(unused generic ZZ: Z where .X = {.r: ()}) {}
|