mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 19:18:11 +00:00
Dana Jansens
fcae9610bd
The type `type` is now a `FacetType` inst with no constraints. This brings the model implemented in the toolchain into better alignment with the language design. The `SemIR::TypeType` struct remains as a scope for holding the `TypeInstId`, `ConstantId`, and `TypeId` constants, but is not an `InstKind` anymore. The `TypeType` inst looks a lot like singletons, but there are many `FacetType` insts so it doesn't quite fit that model. So we put it alongside singletons with a fixed inst id but refer to it as a more general "builtin" inst that is not a singleton. `Namespace::PackageInstId` is similar, and we group it with `TypeType` conceptually as another builtin instruction with a fixed id. No conversion is needed anymore to use a `type` as a facet, since types also have a `FacetType` type. This simplifies and removes a number of helpers and branches throughout the code. The `TypeType` inst is now part of the constant store, so we end up printing it in the constants block in every test. But it's also named `type` rather than `%type` to preserve the majority of existing formatting behaviour, though this does look different from other constants. Assisted-by: Opus 5 was used to generate a first draft and validate the refactoring. Though nearly everything non-trivial the tool wrote has been modified or rewritten.
54 lines
2.1 KiB
Plaintext
54 lines
2.1 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/primitives.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/builtins/float/less.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/builtins/float/less.carbon
|
|
|
|
// --- float_less.carbon
|
|
|
|
fn Less(a: f64, b: f64) -> bool = "float.less";
|
|
fn Negate(a: f64) -> f64 = "float.negate";
|
|
|
|
class True {}
|
|
class False {}
|
|
|
|
fn F(true_: True, false_: False) {
|
|
true_ as (if Less(1.0, 2.0) then True else False);
|
|
false_ as (if Less(1.0, 1.0) then True else False);
|
|
false_ as (if Less(1.0, 0.0) then True else False);
|
|
true_ as (if Less(Negate(1.0), 0.0) then True else False);
|
|
false_ as (if Less(0.0, Negate(1.0)) then True else False);
|
|
}
|
|
|
|
fn RuntimeCallIsValid(a: f64, b: f64) -> bool {
|
|
//@dump-sem-ir-begin
|
|
return Less(a, b);
|
|
//@dump-sem-ir-end
|
|
}
|
|
|
|
// CHECK:STDOUT: --- float_less.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
|
|
// CHECK:STDOUT: %int_64: Core.IntLiteral = int_value 64 [concrete]
|
|
// CHECK:STDOUT: %f64.dc1: type = class_type @Float, @Float(%int_64) [concrete]
|
|
// CHECK:STDOUT: %Less.type: type = fn_type @Less [concrete]
|
|
// CHECK:STDOUT: %Less: %Less.type = struct_value () [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @RuntimeCallIsValid(%a.param: %f64.dc1, %b.param: %f64.dc1) -> out %return.param: bool {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %Less.ref: %Less.type = name_ref Less, file.%Less.decl [concrete = constants.%Less]
|
|
// CHECK:STDOUT: %a.ref: %f64.dc1 = name_ref a, %a
|
|
// CHECK:STDOUT: %b.ref: %f64.dc1 = name_ref b, %b
|
|
// CHECK:STDOUT: %Less.call: init bool = call %Less.ref(%a.ref, %b.ref)
|
|
// CHECK:STDOUT: return %Less.call
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|