carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
03e693873b07a41447b7992cfdfd8a4d8ac1b1b0
carbon-lang/toolchain/check
T
History
Jon Ross-PerkinsandGeoff Romer 03e693873b Detect control flow in entities nested inside functions (#5336) 
Right now, return_scope_stack is being used to determine whether logic
is in a function scope. However, we need to handle nested entities
inside function scopes. For example where this crashes right now:

```
base class C(B:! bool) {}

fn F() {
  class B {
    extend base: C(true or false);
  }
}
```

This is doing a few things to make this kind of code not crash:

- Split `scope_stack().Push` into `PushForDeclName`, `PushForEntity`,
`PushForExpr`, and `PushForFunction` so that better decisions can be
made about behaviors.
- Hide `return_scope_stack` in the API, instead using interfaces to get
at the underlying data.
- Also using `PushForFunction` to update it similar to the other stacks
that `ScopeStack` manages.
- Add `IsInFunctionScope` as the best way to determine presence in
function scope.
- Remove `PeekIsLexicalScope` since destruction really wants function
scope information anyways.
- Clean up `destroy_id_stack` handling to be for function scopes rather
than lexical scopes.
- Return after related `context.TODO`s in a couple more spots, so that
code doesn't proceed to add control flow in spite of the lack of
support.

---------

Co-authored-by: Geoff Romer <gromer@google.com>
2025-04-23 19:03:53 +00:00
..
fuzzer_corpus
Change array syntax from [T; N] to array(T, N) (#4981)
2025-02-20 22:42:47 +00:00
testdata
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
action.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
action.h
Even more usage of TypeInstId (#5296)
2025-04-11 21:47:43 +00:00
BUILD
Introduce FindIfOrNull() FindIfOrNone() and Contains() (#5322)
2025-04-18 14:17:48 +00:00
call.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
call.h
Use As and ImplicitAs interfaces for conversions. (#4209)
2024-09-05 23:39:58 +00:00
check_fuzzer.cpp
Switch Driver back to parameters for construction (#4849)
2025-01-27 23:48:44 +00:00
check_unit.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
check_unit.h
Emit function definitions in check, for all specifics seen. (#5090)
2025-04-02 21:51:25 +00:00
check.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
check.h
Use DiagnosticEmitter for phase-specific types (#5188)
2025-03-27 00:41:30 +00:00
class.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
class.h
Remove all remaining uses of TypeIds as instruction operands. (#5280)
2025-04-10 20:53:42 +00:00
context.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
context.h
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
control_flow.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
control_flow.h
Support destruction of storage (#5171)
2025-03-28 00:29:17 +00:00
convert.cpp
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
convert.h
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
decl_introducer_state.h
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
decl_name_stack.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
decl_name_stack.h
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
deduce.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
deduce.h
Avoid UAF in impl lookup when deduce imports an impl from Core (#5126)
2025-03-14 00:44:51 +00:00
deferred_definition_worklist.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
deferred_definition_worklist.h
Split deferred node traversal out from check.cpp (#4559)
2024-11-20 20:58:58 +00:00
diagnostic_emitter.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
diagnostic_emitter.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
diagnostic_helpers.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
dump.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
eval_inst.cpp
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
eval_inst.h
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
eval.cpp
Add builtins for compound assignment operators. (#5335)
2025-04-21 20:38:11 +00:00
eval.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
facet_type.cpp
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
facet_type.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
full_pattern_stack.h
Clean up handling of Call params (#5061)
2025-03-04 21:01:59 +00:00
function.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
function.h
Add a no-op builtin function which shouldn't generate code. (#5306)
2025-04-15 00:33:39 +00:00
generic_region_stack.cpp
Stop pushing a fake generic for the duration of check. (#5326)
2025-04-17 21:58:37 +00:00
generic_region_stack.h
Add more empty stack verification (#5020)
2025-03-01 07:56:04 +00:00
generic.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
generic.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
global_init.cpp
[Refactor] Move call_params_id from EntityBase to FunctionFields. (#5146)
2025-03-18 23:49:24 +00:00
global_init.h
Split global init out from InstBlockStack. (#4101)
2024-07-03 17:49:47 +00:00
handle_alias.cpp
Stop pushing a fake generic for the duration of check. (#5326)
2025-04-17 21:58:37 +00:00
handle_array.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
handle_binding_pattern.cpp
Separate fields from other var decls in parse (#5320)
2025-04-22 17:15:53 +00:00
handle_call_expr.cpp
Include the call arguments in the location of a call. (#4602)
2024-12-02 18:51:44 +00:00
handle_choice.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_class.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_codeblock.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_export.cpp
Stop pushing a fake generic for the duration of check. (#5326)
2025-04-17 21:58:37 +00:00
handle_expr_statement.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_file.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_function.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_if_expr.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_if_statement.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_impl.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_import_and_package.cpp
Implement #4864: Core is a keyword (#4909)
2025-02-11 21:33:57 +00:00
handle_index.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
handle_interface.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_let_and_var.cpp
Separate fields from other var decls in parse (#5320)
2025-04-22 17:15:53 +00:00
handle_literal.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
handle_loop_statement.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_match.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_modifier.cpp
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
handle_name.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
handle_named_constraint.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_namespace.cpp
Stop pushing a fake generic for the duration of check. (#5326)
2025-04-17 21:58:37 +00:00
handle_noop.cpp
Abort checking when encountering an invalid parse node (#4700)
2024-12-18 00:19:12 +00:00
handle_operator.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_paren_expr.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_pattern_list.cpp
Remove all remaining uses of TypeIds as instruction operands. (#5280)
2025-04-10 20:53:42 +00:00
handle_return_statement.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_struct.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle_tuple_literal.cpp
Remove all remaining uses of TypeIds as instruction operands. (#5280)
2025-04-10 20:53:42 +00:00
handle_where.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
handle.h
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
impl_lookup.cpp
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
impl_lookup.h
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
impl.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
impl.h
Split the witness table into a separate ImplWitnessTable instruction (#5272)
2025-04-11 20:30:04 +00:00
import_cpp.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
import_cpp.h
Add support for importing a trivial global C++ function (#5033)
2025-03-03 10:38:19 +00:00
import_ref.cpp
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
import_ref.h
When diagnosing a duplicated name, add the name to the diagnosis (#4902)
2025-02-19 07:19:23 +00:00
import.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
import.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
inst_block_stack.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
inst_block_stack.h
Invalid comment cleanup (#4836)
2025-01-23 02:21:48 +00:00
inst.cpp
Stop substituting into MetaInstId operands. (#5328)
2025-04-21 21:19:14 +00:00
inst.h
Even more usage of TypeInstId (#5296)
2025-04-11 21:47:43 +00:00
interface.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
interface.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
keyword_modifier_set.h
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
lexical_lookup.h
Refactor value store code to use separate files. (#4477)
2024-11-04 04:00:17 +00:00
literal.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
literal.h
Factor out machinery for forming int type literals. (#4616)
2024-12-03 18:46:27 +00:00
member_access.cpp
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
member_access.h
Store an InterfaceId and a SpecificId in AssociatedEntityType. (#5252)
2025-04-05 16:08:09 +00:00
merge.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
merge.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
modifiers.cpp
Allow extend final impl as for impl declarations (#5345)
2025-04-23 15:20:18 +00:00
modifiers.h
Refactor modifier formatting to remove string passing. (#4418)
2024-10-17 22:47:40 +00:00
name_component.cpp
Fix parse support for 'fn F[];' (#5135)
2025-03-18 00:31:17 +00:00
name_component.h
Id::Invalid -> Id::None (#4834)
2025-01-22 23:15:00 +00:00
name_lookup.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
name_lookup.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
node_id_traversal.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
node_id_traversal.h
Change NodeIdTraversal.context_ from reference to pointer (#5210)
2025-03-28 16:24:17 +00:00
node_stack.cpp
Avoid redundantly specifying Id::Kind. (#4911)
2025-02-07 22:35:18 +00:00
node_stack.h
Separate fields from other var decls in parse (#5320)
2025-04-22 17:15:53 +00:00
operator.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
operator.h
Move diagnostic usings off Context (#5007)
2025-02-26 18:44:36 +00:00
param_and_arg_refs_stack.h
Consolidate post-check logic (#5003)
2025-02-25 02:07:43 +00:00
pattern_match.cpp
Add missing standard library header inclusions (#5316)
2025-04-17 15:37:57 +00:00
pattern_match.h
Invalid comment cleanup (#4836)
2025-01-23 02:21:48 +00:00
pending_block.h
Change PendingBlock.context_ from reference to pointer (#5209)
2025-03-28 16:24:11 +00:00
pointer_dereference.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
pointer_dereference.h
Handle arrow operator (#3768)
2024-03-18 17:40:00 +00:00
region_stack.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
return.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
return.h
Model var as a pattern operator (#4720)
2025-01-17 17:51:34 +00:00
scope_index.h
Move None to IdBase (#5030)
2025-03-01 08:00:17 +00:00
scope_stack.cpp
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
scope_stack.h
Detect control flow in entities nested inside functions (#5336)
2025-04-23 19:03:53 +00:00
subpattern.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
subpattern.h
Support tuple patterns outside parameter lists (#4923)
2025-02-20 03:17:45 +00:00
subst.cpp
Stop substituting into MetaInstId operands. (#5328)
2025-04-21 21:19:14 +00:00
subst.h
Even more usage of TypeInstId (#5296)
2025-04-11 21:47:43 +00:00
type_completion.cpp
Rename singleton InstId constants to TypeInstId (#5323)
2025-04-17 18:57:20 +00:00
type_completion.h
Remove the SemIRLoc typedef (#5299)
2025-04-14 14:28:15 +00:00
type_structure.cpp
Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)
2025-04-15 22:40:29 +00:00
type_structure.h
Include all symbolic parts in structure comparison (#5247)
2025-04-08 19:02:55 +00:00
type.cpp
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00
type.h
Always use LookupImplWitness instructions for symbolic witnesses (#5321)
2025-04-23 16:39:09 +00:00