Files
carbon-lang/toolchain/check/dump.cpp
T
Dana JansensandJon Ross-Perkins 315e206ff1 Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)
Remove calls to `InstStore::GetLocId()` to build a LocId from an InstId
now that they can be constructed directly from the InstId. Most uses of
LocId are just plumbing, so this does not affect them. However places
that want to look inside the LocId do not want to work with the InstId
form. In these places, introduce `InstStore::GetResolvedLocId()` which
converts a LocId (or an InstId as an optimization) into a LocId which is
not backed by an InstId. These locations can be printed (they have a
line and column when they are a NodeId), they can have flags added to
them (`ToImplicit`, `ToTokenOnly`), they can be converted to an
underlying ImportIRInstId, or they may be `None`.

`Dump()` is made to print a resolved location instead of printing the
InstId in the location, since (at least in my experience) the resolved
location is what is interesting in debugging, and this saves manual
`MakeInstId` steps in the debugger every time a location is of interest.

The LocId constructor from InstId is made `explicit` to add clarity to
function calls passing an `inst_id` now directly instead of calling
`context.insts().GetLocId(inst_id)`. To avoid needing to construct
`SemIR::LocId(...)` explicitly in all cases though, the diagnostics code
in Check uses `DiagnosticLocId` as its template parameter which accepts
InstId as well and does the construction of LocId from it.

Because LocId now requires an explicit construction from InstId, any
callers to `AddInst()` functions will have to explicitly convert to
LocId if they had an InstId, but not if they pass a NodeId. To make this
difference clear to callers, we `requires` that the input type can be
converted to LocId. This ensures that passing an InstId results in an
error at the callsite where the InstId is passed, instead of generating
a compiler error when trying to construct `LocIdAndInst` inside
`AddInst()`, which is less clear about what went wrong and doesn't seem
entirely intentional.

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
2025-04-28 19:06:24 +00:00

192 lines
6.3 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// This library contains functions to assist dumping objects to stderr during
// interactive debugging. Functions named `Dump` are intended for direct use by
// developers, and should use overload resolution to determine which will be
// invoked. The debugger should do namespace resolution automatically. For
// example:
//
// - lldb: `expr Dump(context, id)`
// - gdb: `call Dump(context, id)`
#ifndef NDEBUG
#include "toolchain/lex/dump.h"
#include <string>
#include "common/check.h"
#include "common/raw_string_ostream.h"
#include "toolchain/check/context.h"
#include "toolchain/lex/tokenized_buffer.h"
#include "toolchain/parse/dump.h"
#include "toolchain/parse/tree.h"
#include "toolchain/sem_ir/dump.h"
#include "toolchain/sem_ir/file.h"
namespace Carbon::Check {
static auto Dump(const Context& context, SemIR::LocId loc_id) -> std::string;
LLVM_DUMP_METHOD static auto Dump(const Context& context, Lex::TokenIndex token)
-> std::string {
return Parse::Dump(context.parse_tree(), token);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context, Parse::NodeId node_id)
-> std::string {
return Parse::Dump(context.parse_tree(), node_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::ClassId class_id) -> std::string {
return SemIR::Dump(context.sem_ir(), class_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::ConstantId const_id) -> std::string {
return SemIR::Dump(context.sem_ir(), const_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::EntityNameId entity_name_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), entity_name_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::FacetTypeId facet_type_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), facet_type_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::FunctionId function_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), function_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::GenericId generic_id) -> std::string {
return SemIR::Dump(context.sem_ir(), generic_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context, SemIR::ImplId impl_id)
-> std::string {
RawStringOstream out;
out << SemIR::Dump(context.sem_ir(), impl_id);
if (!impl_id.has_value()) {
return out.TakeStr();
}
const auto& impl = context.sem_ir().impls().Get(impl_id);
out << "\nwitness loc: " << Dump(context, SemIR::LocId(impl.witness_id));
return out.TakeStr();
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::InstBlockId inst_block_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), inst_block_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context, SemIR::InstId inst_id)
-> std::string {
RawStringOstream out;
out << SemIR::Dump(context.sem_ir(), inst_id) << '\n'
<< " - " << Dump(context, SemIR::LocId(inst_id));
return out.TakeStr();
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::InterfaceId interface_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), interface_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context, SemIR::LocId loc_id)
-> std::string {
RawStringOstream out;
// TODO: If the canonical location is None but the original is an InstId,
// should we dump the InstId anyway even though it has no location? Is that
// ever useful?
loc_id = context.sem_ir().insts().GetCanonicalLocId(loc_id);
switch (loc_id.kind()) {
case SemIR::LocId::Kind::None: {
out << "LocId(<none>)";
break;
}
case SemIR::LocId::Kind::ImportIRInstId: {
auto import_ir_id = context.sem_ir()
.import_ir_insts()
.Get(loc_id.import_ir_inst_id())
.ir_id();
const auto* import_file =
context.sem_ir().import_irs().Get(import_ir_id).sem_ir;
out << "LocId(import from \"" << FormatEscaped(import_file->filename())
<< "\")";
break;
}
case SemIR::LocId::Kind::NodeId: {
auto token = context.parse_tree().node_token(loc_id.node_id());
auto line = context.tokens().GetLineNumber(token);
auto col = context.tokens().GetColumnNumber(token);
const char* implicit = loc_id.is_implicit() ? " implicit" : "";
out << "LocId(" << FormatEscaped(context.sem_ir().filename()) << ":"
<< line << ":" << col << implicit << ")";
break;
}
case SemIR::LocId::Kind::InstId:
CARBON_FATAL("unexpected LocId kind");
}
return out.TakeStr();
}
LLVM_DUMP_METHOD static auto Dump(const Context& context, SemIR::NameId name_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), name_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::NameScopeId name_scope_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), name_scope_id);
}
LLVM_DUMP_METHOD static auto Dump(
const Context& context,
SemIR::IdentifiedFacetTypeId identified_facet_type_id) -> std::string {
return SemIR::Dump(context.sem_ir(), identified_facet_type_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::SpecificId specific_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), specific_id);
}
LLVM_DUMP_METHOD static auto Dump(
const Context& context, SemIR::SpecificInterfaceId specific_interface_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), specific_interface_id);
}
LLVM_DUMP_METHOD static auto Dump(
const Context& context, SemIR::StructTypeFieldsId struct_type_fields_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), struct_type_fields_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context, SemIR::TypeId type_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), type_id);
}
} // namespace Carbon::Check
#endif // NDEBUG