mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 19:30:12 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
65 lines
2.4 KiB
C++
65 lines
2.4 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_SEM_IR_REQUIRE_IMPLS_H_
|
|
#define CARBON_TOOLCHAIN_SEM_IR_REQUIRE_IMPLS_H_
|
|
|
|
#include "toolchain/base/block_value_store.h"
|
|
#include "toolchain/base/canonical_value_store.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
// An interface requirement from an interface or named constraint, written
|
|
// `require T impls Z`.
|
|
//
|
|
// While this comes from a `require` declaration, it is not an Entity like most
|
|
// other declarations, with a name and parameters, so it does not inherit
|
|
// EntityWithParamsBase.
|
|
struct RequireImpls : Printable<RequireImpls> {
|
|
// The self-type which must implement a given facet type.
|
|
TypeInstId self_id;
|
|
// Evaluates to the `FacetType` that the self-type must implement.
|
|
TypeInstId facet_type_inst_id;
|
|
// If the facet type extends `Self`. When true, the `self_id` will be `Self`.
|
|
bool extend_self;
|
|
|
|
// The location of the `require` declaration.
|
|
InstId decl_id;
|
|
// The interface or named constraint which contains the `require` declaration.
|
|
NameScopeId parent_scope_id;
|
|
// A `require` declaration is always generic over `Self` since it's inside an
|
|
// interface or named constraint definition.
|
|
GenericId generic_id;
|
|
|
|
auto Print(llvm::raw_ostream& out) const -> void {
|
|
out << '{';
|
|
out << "self_id: " << self_id
|
|
<< ", facet_type_inst_id: " << facet_type_inst_id
|
|
<< ", extend_self: " << (extend_self ? "true" : "false")
|
|
<< ", parent_scope: " << parent_scope_id;
|
|
out << '}';
|
|
}
|
|
};
|
|
|
|
using RequireImplsStore =
|
|
ValueStore<RequireImplsId, RequireImpls, Tag<CheckIRId>>;
|
|
|
|
using RequireImplsBlockStore =
|
|
BlockValueStore<RequireImplsBlockId, RequireImplsId, Tag<CheckIRId>>;
|
|
|
|
} // namespace Carbon::SemIR
|
|
|
|
namespace Carbon {
|
|
extern template class ValueStore<SemIR::RequireImplsId, SemIR::RequireImpls,
|
|
Tag<SemIR::CheckIRId>>;
|
|
extern template class ValueStore<SemIR::RequireImplsBlockId,
|
|
llvm::MutableArrayRef<SemIR::RequireImplsId>,
|
|
Tag<SemIR::CheckIRId>>;
|
|
extern template class BlockValueStore<
|
|
SemIR::RequireImplsBlockId, SemIR::RequireImplsId, Tag<SemIR::CheckIRId>>;
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_SEM_IR_REQUIRE_IMPLS_H_
|