mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 04:28:14 +00:00
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
86 lines
3.6 KiB
Plaintext
86 lines
3.6 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/int.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/let/ref.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/let/ref.carbon
|
|
|
|
// --- local.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
fn F(a: i32) {
|
|
var b: i32 = a;
|
|
//@dump-sem-ir-begin
|
|
let ref c: i32 = b;
|
|
let (unused ref d: i32, unused ref e: i32) = (b, c);
|
|
//@dump-sem-ir-end
|
|
}
|
|
|
|
// --- fail_ref_to_value.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
fn F(a: i32) {
|
|
// CHECK:STDERR: fail_ref_to_value.carbon:[[@LINE+2]]:27: error: cannot bind durable reference to non-reference value of type `i32` [ConversionFailureNonRefToRef]
|
|
// CHECK:STDERR:
|
|
let unused ref b: i32 = a;
|
|
}
|
|
|
|
// --- fail_ref_to_temporary.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
fn G() -> i32;
|
|
|
|
fn F() {
|
|
// CHECK:STDERR: fail_ref_to_temporary.carbon:[[@LINE+2]]:27-29: error: cannot bind durable reference to non-reference value of type `i32` [ConversionFailureNonRefToRef]
|
|
// CHECK:STDERR:
|
|
let unused ref a: i32 = G();
|
|
}
|
|
|
|
// CHECK:STDOUT: --- local.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: type: type = facet_type <type> [concrete]
|
|
// CHECK:STDOUT: %int_32: Core.IntLiteral = int_value 32 [concrete]
|
|
// CHECK:STDOUT: %i32: type = class_type @Int, @Int(%int_32) [concrete]
|
|
// CHECK:STDOUT: %pattern_type.d94: type = pattern_type %i32 [concrete]
|
|
// CHECK:STDOUT: %c.patt: %pattern_type.d94 = ref_binding_pattern c [concrete]
|
|
// CHECK:STDOUT: %d.patt: %pattern_type.d94 = ref_binding_pattern d [concrete]
|
|
// CHECK:STDOUT: %e.patt: %pattern_type.d94 = ref_binding_pattern e [concrete]
|
|
// CHECK:STDOUT: %tuple.type.35f: type = tuple_type (%i32, %i32) [concrete]
|
|
// CHECK:STDOUT: %pattern_type.354: type = pattern_type %tuple.type.35f [concrete]
|
|
// CHECK:STDOUT: %.136: %pattern_type.354 = tuple_pattern (%d.patt, %e.patt) [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @F(%a.param: %i32) {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: <elided>
|
|
// CHECK:STDOUT: %b.ref.loc7: ref %i32 = name_ref b, %b
|
|
// CHECK:STDOUT: %i32.loc7: type = type_literal constants.%i32 [concrete = constants.%i32]
|
|
// CHECK:STDOUT: %c: ref %i32 = wrapper_binding c, %b.ref.loc7
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %c.patt: %pattern_type.d94 = ref_binding_pattern c [concrete = constants.%c.patt]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %b.ref.loc8: ref %i32 = name_ref b, %b
|
|
// CHECK:STDOUT: %c.ref: ref %i32 = name_ref c, %c
|
|
// CHECK:STDOUT: %.loc8_53: %tuple.type.35f = tuple_literal (%b.ref.loc8, %c.ref)
|
|
// CHECK:STDOUT: %i32.loc8_22: type = type_literal constants.%i32 [concrete = constants.%i32]
|
|
// CHECK:STDOUT: %d: ref %i32 = wrapper_binding d, %b.ref.loc8
|
|
// CHECK:STDOUT: %i32.loc8_41: type = type_literal constants.%i32 [concrete = constants.%i32]
|
|
// CHECK:STDOUT: %e: ref %i32 = wrapper_binding e, %c.ref
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %d.patt: %pattern_type.d94 = ref_binding_pattern d [concrete = constants.%d.patt]
|
|
// CHECK:STDOUT: %e.patt: %pattern_type.d94 = ref_binding_pattern e [concrete = constants.%e.patt]
|
|
// CHECK:STDOUT: %.loc8_44: %pattern_type.354 = tuple_pattern (%d.patt, %e.patt) [concrete = constants.%.136]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: <elided>
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|