mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 09:48:32 +00:00
Chandler Carruth
2c9739799b
Diagnostic rendering was part of the data model: `Loc::FormatLocation` and `Loc::FormatSnippet` wrote plain text to a stream, so no capability, color, or terminal width could reach them. A diagnostic is now one message with labels, contexts, and location information attached, and `Diagnostics::Renderer` draws it into a `Terminal::Buffer`. The design is in `toolchain/docs/diagnostics_rendering.md` (#7668), authoring in `toolchain/docs/diagnostics.md`. Before: ``` example.carbon:6:3: error: 1 argument passed to function expecting 0 arguments Run0(1); ^~~~~~~ example.carbon:3:1: note: calling function declared here fn Run0() {} ^~~~~~~~~~~ ``` After: ``` error: 1 argument passed to function expecting 0 arguments ╭─┤ example.carbon:6:3 ┆ 3 │ fn Run0() {} · ─────┬───── · ╰──┤ calling function declared here ┆ -> 6 │ Run0(1); · ─────── ╰──────────── ``` `--no-diagnostic-snippets` gives a compact form, `example.carbon:6:3-9`. File tests use it; the rendering tests under `toolchain/diagnostics/testdata` ask for snippets. C++ interop diagnostics are data now rather than text Clang drew: `SemIR::ClangSourceLocId` names a `clang::SourceRange`, and a Clang location is marked as the point it names. `StreamConsumer` moves to a `:renderer` target that `:emitter` does not depend on, keeping `common/terminal` out of `consumer.h`. Capabilities come from the file behind the error stream, so tests get plain ASCII. `renderer_fuzzer` draws diagnostics built from fuzzer bytes with every capability combination, since a shape the renderer doesn't expect must never be why the compiler dies while reporting a problem. TODOs mark the follow-ups: line weights and crossing lines, wrapping that keeps a quoted type whole, and ordering diagnostics that share a byte offset. Also: `IncorrectExtension`'s hint moves into its message, since its note had no location of its own, and `strip_noise` in `check_diagnostics.py` blanks multi-line `#define`s instead of deleting them. Assisted-by: Claude Code
69 lines
3.0 KiB
C++
69 lines
3.0 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_CHECK_CPP_CALL_H_
|
|
#define CARBON_TOOLCHAIN_CHECK_CPP_CALL_H_
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
|
|
namespace clang {
|
|
class TemplateArgumentListInfo;
|
|
class TemplateDecl;
|
|
} // namespace clang
|
|
|
|
namespace Carbon::Check {
|
|
|
|
// Converts a call argument list into a Clang template argument list for a given
|
|
// template. Returns true on success, or false if an error was diagnosed.
|
|
//
|
|
// If `diagnose` is false, errors will be suppressed.
|
|
auto ConvertArgsToTemplateArgs(Context& context,
|
|
clang::TemplateDecl* template_decl,
|
|
llvm::ArrayRef<SemIR::InstId> arg_ids,
|
|
clang::TemplateArgumentListInfo& arg_list,
|
|
bool diagnose = true) -> bool;
|
|
|
|
// Checks and builds SemIR for a call to a C++ function in the given overload
|
|
// set with self `self_id` and arguments `arg_ids`. `is_desugared`
|
|
// indicates that this call was was produced by desugaring, not written as a
|
|
// function call in user code, so arguments to `ref` parameters aren't required
|
|
// to have `ref` tags.
|
|
//
|
|
// `callee_expr_id` is the expression naming the overload set, which is what a
|
|
// diagnostic about the call marks.
|
|
//
|
|
// Chooses the best viable C++ function by performing Clang overloading
|
|
// resolution over the overload set.
|
|
//
|
|
// Preserves the given self, if set. If not set, and the function is a C++
|
|
// member operator, self will be set to the first argument, which in turn will
|
|
// be removed from the given args.
|
|
//
|
|
// A set with a single non-templated function goes through the same rules for
|
|
// overloading resolution. This is to make sure that calls that have no viable
|
|
// implicit conversion sequence are rejected even when an implicit conversion is
|
|
// possible. Keeping the same behavior here for consistency and supporting
|
|
// migrations so that the migrated callers from C++ remain valid.
|
|
auto PerformCallToCppFunction(Context& context, SemIR::LocId loc_id,
|
|
SemIR::InstId callee_expr_id,
|
|
SemIR::CppOverloadSetId overload_set_id,
|
|
SemIR::InstId self_id,
|
|
llvm::ArrayRef<SemIR::InstId> arg_ids,
|
|
bool is_desugared) -> SemIR::InstId;
|
|
|
|
// Checks and builds SemIR for a call to a C++ template name with arguments
|
|
// `arg_ids`.
|
|
//
|
|
// Converts the arguments to a C++ template argument list and attempts to
|
|
// instantiate a template specialization and import a declaration of it.
|
|
auto PerformCallToCppTemplateName(Context& context, SemIR::LocId loc_id,
|
|
SemIR::ClangDeclId template_decl_id,
|
|
llvm::ArrayRef<SemIR::InstId> arg_ids)
|
|
-> SemIR::InstId;
|
|
|
|
} // namespace Carbon::Check
|
|
|
|
#endif // CARBON_TOOLCHAIN_CHECK_CPP_CALL_H_
|