carbon-lang

carbon-language/carbon-lang

Fork 0

mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-25 06:10:14 +01:00

Commit Graph

Author SHA1 Message Date

Jon Meow eda43faa5a Note namespace and static recommendations in C++ style guide (#1041 ) 2022-01-27 11:26:47 -08:00

Author	SHA1	Message	Date
Jon Meow	eda43faa5a	Note namespace and static recommendations in C++ style guide (#1041 )	2022-01-27 11:26:47 -08:00
Jon Meow	6fa42a7f3c	For-range `in` replacement logic (#631 ) This replaces GetAstMatcher with AddMatcher because cxxForRangeStmt is a StatementMatcher. addMatcher has multiple definitions (https://clang.llvm.org/doxygen/classclang_1_1ast__matchers_1_1MatchFinder.html) and so this approach allows using the right addMatcher without writing per-call overloads. To handle the `var`, I'm considering something like moving VarDecl logic into a VarMatcherBase so that I can just use CXXForRangeStmt's getLoopVariable. The problem is a for-range statement has multiple VarDecls, and getLoopVariable may be the easiest way to identify the real one.	2021-07-12 16:20:44 -07:00

Jon Meow

6fa42a7f3c

For-range in replacement logic (#631 )

This replaces GetAstMatcher with AddMatcher because cxxForRangeStmt is a StatementMatcher. addMatcher has multiple definitions (https://clang.llvm.org/doxygen/classclang_1_1ast__matchers_1_1MatchFinder.html) and so this approach allows using the right addMatcher without writing per-call overloads.

To handle the `var`, I'm considering something like moving VarDecl logic into a VarMatcherBase so that I can just use CXXForRangeStmt's getLoopVariable. The problem is a for-range statement has multiple VarDecls, and getLoopVariable may be the easiest way to identify the real one.

2021-07-12 16:20:44 -07:00