josh11b and Jon Ross-Perkins
fada410559
Support declaration modifier keywords ( #3412 )
...
Co-authored-by: Jon Ross-Perkins <jperkins@google.com >
2023-12-05 22:45:57 +00:00
Richard Smith
22dff46ed2
Remove support for disambiguating a stringified type as being a type. ( #3456 )
...
Most of the calls to `StringifyType` already passed `true` for
`in_type_context`. Checking the rest, I found that every one of them was
already sufficiently clear that they were printing a type, or could be
made so with a very small change to the diagnostic text.
2023-12-05 17:34:04 +00:00
Richard Smith
433d626b04
Rename SemIR::{Base,Field} -> SemIR::{Base,Field}Decl. ( #3452 )
...
Also fix printing of unbound element type to say "element" not "field"
since we're touching all the relevant SemIR output anyway.
2023-12-05 16:37:02 +00:00
Richard Smith
7dffa0c7ec
Support for base: T;, .base, x.base. ( #3450 )
...
No support for `extend base` yet, in an effort to minimize collisions
with #3412 .
2023-12-04 22:45:59 +00:00
Jon Ross-Perkins
30155dbb72
Add support for 'package' in expressions. ( #3445 )
...
This creates a namespace for `package` scope.
It looks like names of class_decls in namespaces lead to an unexpected
instref. This is already true, as best as I can tell. I'm not sure if
there's a preferred approach to address that, so I've left a TODO for
now.
2023-12-04 21:05:41 +00:00
josh11b
1c4a35c76b
Remove llvm::StringRef from diagnostic example ( #3451 )
...
To match new guidance to avoid lifetime issues (now documented at
https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.nlcon9stg5pg
)
2023-12-04 16:10:38 +00:00
Jon Ross-Perkins and Richard Smith
962defd1e8
Associate a name with ClassDecl ( #3447 )
...
Note generics will probably need different behavior.
---------
Co-authored-by: Richard Smith <richard@metafoo.co.uk >
2023-12-02 00:44:57 +00:00
Richard Smith
ca53c18ddc
Rename MemberIndex -> ElementIndex, ClassFieldAccess -> ClassElementAccess, UnboundFieldType -> UnboundElementType. ( #3446 )
...
In preparation for base class support, where these types will be used
for bases as well as fields.
As discussed [on
discord](https://discord.com/channels/655572317891461132/963846118964350976/1180267686316478575 ).
2023-12-02 00:29:48 +00:00
Richard Smith and Jon Ross-Perkins
9c46d15f78
Distribute autoupdate across threads. ( #3443 )
...
Also switch how we ensure that stdin is closed for tests, so that `bazel
run` doesn't hang if invoked manually.
---------
Co-authored-by: Jon Ross-Perkins <jperkins@google.com >
2023-12-02 00:26:16 +00:00
Geoff Romer
b8d4e2f41b
Binding pattern naming cleanup ( #3410 )
...
- Rename `PatternBinding` to `BindingPattern`.
- Use `BindingPattern` rather than `Pattern` in the names of
binding-pattern-specific parse states.
2023-12-01 21:36:51 +00:00
Jon Ross-Perkins
132807e138
Refactor ValueStore to reduce template type repetition. ( #3437 )
...
There's a trade-off here of explicitness in the use versus repetition,
but I'm hoping the Id offers sufficient info (also, some Ids already
relied on this, so this builds consistency). The forward declarations
I'm mixed on, but they are difficult to avoid if heading down this route
due to interdependencies between ids and types which contain ids.
2023-12-01 02:10:02 +00:00
Jon Ross-Perkins
aa5bfa564f
Add a distinct semir file separator. ( #3438 )
...
This removes the filename from the file-scoped block, and places it
above to make it clear where the full SemIR begins (with multifile,
providing a barrier between).
2023-12-01 00:53:45 +00:00
Richard Smith
c6bc2cbb3d
Rename IndexBase -> IdBase, ComparableIndexBase -> IndexBase. ( #3436 )
...
This reflects how we're naming classes that derive from these classes,
and matches usage for each existing `Id` and `Index` type, except:
- `Parse::NodeId` previously inherited from `ComparableIndexBase`, and
is no longer comparable.
- `SemIR::MemberIndex` previously inherited from `IndexBase`, and is now
comparable.
Making `Parse::NodeId` non-comparable reflects that it's intended to be
an opaque identifier for a node and that the ordering is an
implementation detail rather than part of the intended public interface.
`PostorderIterator` and `SiblingIterator` still rely on the numerical
meaning of `NodeId`s, but that's OK since they're part of the node
implementation.
2023-11-30 18:50:59 +00:00
Jon Ross-Perkins
05723095bc
Switch formatv adapters to format_provider ( #3434 )
...
The main difference I'm aiming for is that clangd doesn't complain about
the struct being unused, but it does miss the function's use. But really
these are specific to formatv for diagnostics, so this is more clearly
marking such, and probably makes for a better pattern for the future.
2023-11-30 18:33:03 +00:00
Jon Ross-Perkins
0db63ff17a
Abbreviate Integer and FloatingPoint ( #3435 )
...
I was suggesting this because `FloatingPoint` is pretty long. `int` and
`float` should be familiar abbreviations. `unsigned` should be familiar
to developers too, but `UnsignedInt` still feels usefully clearer for
the additional chars.
2023-11-29 23:29:48 +00:00
Jon Ross-Perkins and Richard Smith
0d618b1278
Tidy up lint issues. ( #3429 )
...
These are manual fixes; mostly from clang-tidy, some from clangd (which
notes unused includes).
In typed_insts, adding inlline due to misc-definitions-in-headers. Per
discussion, clang-tidy is wrong, but inline silences it.
For parameter name skew in definition versus declaration, I'm just using
the name from the definition.
---------
Co-authored-by: Richard Smith <richard@metafoo.co.uk >
2023-11-29 20:41:53 +00:00
Richard Smith
eae630a3db
Rename Lex::{Token,Line} -> Lex::{Token,Line}Index. ( #3433 )
...
As discussed [on
discord](https://discord.com/channels/655572317891461132/655578254970716160/1178878128714678282 )
and today's toolchain discussion.
2023-11-29 20:33:58 +00:00
Richard Smith
332a368cee
Rename Parse::Node -> Parse::NodeId. ( #3432 )
...
As discussed [on
discord](https://discord.com/channels/655572317891461132/655578254970716160/1178878128714678282 )
and today's toolchain discussion.
2023-11-29 18:53:12 +00:00
Jon Ross-Perkins and Chandler Carruth
0c0998d7cd
Error when passing StringRef to CARBON_DIAGNOSTIC. ( #3431 )
...
This gets to a lifetime subtlety, particularly with things like the
sorting diagnostic consumer that delay output. In order to reduce the
chance of accidental references, disallow StringRef in the diagnostics.
For example:
```
./toolchain/diagnostics/diagnostic_emitter.h:162:5: error: static_assert failed due to requirement '!std::is_same_v<llvm::StringRef, llvm::StringRef>' "Use std::string or llvm::StringLiteral for diagnostic lifetimes."
static_assert(
^
toolchain/check/convert.cpp:477:11: note: in instantiation of member function 'Carbon::Internal::DiagnosticBase<std::string, std::string, llvm::StringRef>::DiagnosticBase' requested here
CARBON_DIAGNOSTIC(StructInitMissingFieldInConversion, Error,
^
./toolchain/diagnostics/diagnostic_emitter.h:47:7: note: expanded from macro 'CARBON_DIAGNOSTIC'
::Carbon::Internal::DiagnosticBase<__VA_ARGS__>( \
^
```
---------
Co-authored-by: Chandler Carruth <chandlerc@gmail.com >
2023-11-29 17:04:11 +00:00
Jon Ross-Perkins
161f46ed37
FloatingPointLiteral to RealLiteral fixup ( #3430 )
2023-11-29 17:00:03 +00:00
Jon Ross-Perkins
3f208e27f9
Align on FileStart/FileEnd for naming. ( #3428 )
...
The lexer has been using EndOfFile form (stemming from EOF), parser went
to FileEnd form. This consolidates on FileEnd form.
2023-11-29 16:36:57 +00:00
Jon Ross-Perkins
239f8030a4
Pass imports to SemIR. ( #3415 )
...
This adds instructions so that we get printing. I may adjust the
instruction format a little further to add a type, but I think the basic
setup will remain.
Note this builds on #3414
2023-11-28 19:55:38 +00:00
Jon Ross-Perkins
35d15a390c
Remove nodiscard uses. ( #3418 )
...
Per [#toolchain
discussion](https://discord.com/channels/655572317891461132/655578254970716160/1176632520834560211 )
We'd at one point been trying to put `[[nodiscard]]` everywhere, but
then we stopped because it had felt verbose without finding many issues
(plus, people plain forgot to add it). Some history in #888 .
Since newer code gets added without it, we now have code like:
```
auto GetLineInfo(Line line) -> LineInfo&;
[[nodiscard]] auto GetLineInfo(Line line) const -> const LineInfo&;
auto AddLine(LineInfo info) -> Line;
auto GetTokenInfo(Token token) -> TokenInfo&;
[[nodiscard]] auto GetTokenInfo(Token token) const -> const TokenInfo&;
auto AddToken(TokenInfo info) -> Token;
[[nodiscard]] auto GetTokenPrintWidths(Token token) const -> PrintWidths;
```
Here, the lack of `[[nodiscard]]` doesn't mean anything: for example,
`GetLineInfo` should not have its result discarded if it's called. But
the mix could be confusing for readers.
As a resolution, remove the attribute. `[[nodiscard]]` should be treated
like other attributes going forward, which essentially means "avoid in
general, add a comment to explain why the attribute is needed" rather
than use-as-default.
2023-11-28 18:46:19 +00:00
josh11b
a307e7a72a
Rename files to use "expr" and "deref" ( #3426 )
...
Follows #3425 and #3375 .
2023-11-28 17:11:35 +00:00
Jon Ross-Perkins
7f53a792c0
Fix crash when array contents aren't an expression. ( #3424 )
...
FloatingPointLiteral wrap is a clang-format thing. I didn't touch it
manually.
2023-11-27 23:35:01 +00:00
josh11b
c89c452579
Abbreviate "Reference" -> "Ref", "Dereference" -> "Deref" ( #3425 )
...
Part of switching to the [abbreviations we've decided to
use](https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.pph7i5m5un7q ).
File renames will be done separately.
2023-11-27 23:30:31 +00:00
Jacob Schneider
1d443a3617
Underline the entire token when producing diagnostic messages. ( #3413 )
...
This is an incremental improvement on our diagnostic messages that
simply underlines an entire token if the token is larger than 1 char
(else it points to the single char with a caret like it used to).
2023-11-27 16:36:26 +00:00
Richard Smith
790a5f93c7
Fix minor typos / grammar errors in the driver. ( #3420 )
2023-11-22 23:52:08 +00:00
Jon Ross-Perkins
5522e4f613
Switch cross references to a ValueStore. ( #3414 )
...
As I get ready to add imports, I need an API to add values and this
offers a consistent way of doing so.
2023-11-22 21:43:17 +00:00
Richard Smith and Chandler Carruth
9154c6410e
Support for reading source code from stdin and other unusual places. ( #3416 )
...
- Treat an input of `-` as meaning stdin.
- Fix building of an llvm::MemoryBuffer from a non-regular file.
- Do not enforce filename restrictions on non-regular files.
- Do not invent an output file name based on the name of a non-regular
file.
---------
Co-authored-by: Chandler Carruth <chandlerc@gmail.com >
2023-11-22 03:48:10 +00:00
Jon Ross-Perkins
a204689893
Use more specific node kinds for literals. ( #3419 )
...
Sounding out the approach, to make it clearer what a literal node
corresponds to.
2023-11-22 01:27:28 +00:00
Jon Ross-Perkins
9d369db8ea
Diagnose incorrect file extensions. ( #3409 )
...
Note this is building on #3408
2023-11-20 23:49:10 +00:00
Jon Ross-Perkins
456d165258
Diagnose repeat Main//default files as a redundant api file. ( #3408 )
2023-11-17 20:10:56 +00:00
josh11b
df9494a948
Restore interface declaration parse test ( #3406 )
...
The declaration test was made the same as the empty body test in #2649 .
This change restores it to test parsing a forward declaration of an
interface.
2023-11-16 18:48:39 +00:00
Chandler Carruth
d3eae6d1f0
Fix a crash on invalid found by fuzzing. ( #3404 )
...
When a `namespace` keyword has no `;` following it, we recover by
building a parse tree `Namespace` node from the `Namespace` token (as
there isn't a `;` token). Allow this correspondence on errors.
Also teach the diagnostics in this case to avoid the end-of-file token
as that's almost always going to be a less meaningful location. Instead,
we can point at the introducer which should at least be in the code that
led to the error.
2023-11-16 18:26:39 +00:00
Jon Ross-Perkins
204c04dbb9
Add more package and import support. ( #3402 )
...
This should cover:
```
library "lib" api;
import Foo library default;
import library default;
import library "lib";
```
This splits out `PackageName` and `LibraryName` to their own parse nodes
so that checking can ignore them and still get a balanced parse tree
(otherwise, we essentially need to implement handling of the parse nodes
only to remove the identifiers/string literals -- the optional names
mean we can't blindly do that as before). For reference, these nodes
don't need to be handled because CheckParseTree will need to directly
funnel import information along with checked IRs.
2023-11-16 17:09:36 +00:00
josh11b and Richard Smith
d21e7b4f14
Detect duplicate member names in struct and struct type literals ( #3395 )
...
A struct with the same member name twice can cause a `CARBON_CHECK`
failure later when it is used (problem found by fuzzing).
---------
Co-authored-by: Richard Smith <richard@metafoo.co.uk >
2023-11-15 06:12:03 +00:00
josh11b
7d8afed6f7
Abbreviate "Initialization" -> "Init" ( #3398 )
...
Part of switching to the [abbreviations we've decided to
use](https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.pph7i5m5un7q ).
2023-11-15 05:36:16 +00:00
josh11b
7af364c12c
Don't abbreviate 'element' ( #3400 )
...
Decision:
https://discord.com/channels/655572317891461132/655578254970716160/1174103988317212692
2023-11-15 05:24:09 +00:00
josh11b
729ea69385
parameter -> param file renaming (#3397 )
...
Finishes work started in #3392
2023-11-14 22:29:16 +00:00
Jon Ross-Perkins and Richard Smith
d024403dc4
Refactor checking flow to allow for ordering based on import/package. ( #3379 )
...
As I was working on this, I noticed `import` and `library` syntax needs
to be fixed for how it imports the current package, and for `Main`
libraries. This mostly reflects the current state in its testing.
Otherwise, this should handle most of the errors I could think of:
dependency cycles, redundant imports, etc.
It does not actually deal with the nuances of cross-IR references.
---------
Co-authored-by: Richard Smith <richard@metafoo.co.uk >
2023-11-14 22:24:03 +00:00
Richard Smith and Jon Ross-Perkins
2715e2276e
Parsing and basic checking for abstract class and base class. ( #3385 )
...
For now, we require the same introducer to be used each time a class is
declared, but see #3384 .
---------
Co-authored-by: Jon Ross-Perkins <jperkins@google.com >
2023-11-13 20:38:21 +00:00
Richard Smith
49591d1360
Add some testing that self and Self don't conflict with r#self and r#Self. ( #3381 )
2023-11-13 20:24:07 +00:00
josh11b and Jon Ross-Perkins
c53b248800
Abbreviate "parameter" -> "param" ( #3392 )
...
Part of switching to the [abbreviations we've decided to
use](https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.pph7i5m5un7q ).
I will rename files in a follow-up PR.
---------
Co-authored-by: Jon Ross-Perkins <jperkins@google.com >
2023-11-13 19:06:54 +00:00
josh11b
522dcc44c5
Finish "declaration" -> "decl" ( #3391 )
...
Some new uses of "declaration" introduced in #3374 were missed in #3382
since #3374 was still in flight.
2023-11-13 16:01:40 +00:00
Jacob Schneider
482d233def
fix crash caused by unicode chars ( #3387 )
...
Prevent a crash during lexing for unicode chars.
2023-11-11 06:27:15 +00:00
Richard Smith
abedf08816
Reduce the compile time of the typed_insts_test by a further 40% or so. ( #3390 )
...
Move the non-dependent portions of templates out into separate functions
so that we don't need to repeatedly generate code for them.
2023-11-11 00:31:55 +00:00
josh11b
109e7889dd
Rename files to use abbreviations ( #3389 )
...
Reflects these recent PRs:
* #3375
* #3382
2023-11-11 00:25:40 +00:00
Jon Ross-Perkins and Chandler Carruth
cafcd88882
Split lexing logic and storage to separate files. ( #3365 )
...
Just reorganizing logic a little, trying to mirror the direction we've
gone with check, lower, etc. That is, lex.h contains a function `Lex`
that is used directly.
Note, I'm avoiding making meaningful changes here. It could in theory
still affect inlining in benchmarks, but I'm not seeing an impact.
Before:
```
------------------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
------------------------------------------------------------------------------------------------------
BM_ValidKeywords 2784949 ns 2784867 ns 249 bytes_per_second=214.452M/s tokens_per_second=35.9084M/s
BM_ValidKeywordsAsRawIdentifiers 3222597 ns 3222551 ns 210 bytes_per_second=244.513M/s tokens_per_second=31.0313M/s
BM_RawIdentifierFocus 5907836 ns 5907518 ns 103 bytes_per_second=264.873M/s tokens_per_second=16.9276M/s
BM_ValidIdentifiers<1, 64, false> 6255128 ns 6254297 ns 105 bytes_per_second=235.488M/s tokens_per_second=15.989M/s
BM_ValidIdentifiers<1, 1, true> 36776305518589chandlerc@gmail.com >
2023-11-10 23:59:49 +00:00
josh11b
11d79a3882
Use x-macro instead of TYPED_TEST for compilation speed ( #3388 )
...
Reduces total time to build and run just this test from 25+ seconds to
~16 seconds.
2023-11-10 23:34:13 +00:00
josh11bandJon Ross-Perkins
Richard Smith
Geoff Romer
Jacob Schneider