Commit Graph
7 Commits
Author SHA1 Message Date
Jon Meow 98ebae62a6 Update pre-commit versions and fix black break (#160)
Caught by black stable change, done by `pre-commit autoupdate`

`pre-commit autoupdate` also wanted to update pre-commit-hooks, but that gave me some pyenv errors so I'm leaving it alone for now.
2020-09-15 09:00:24 -07:00
Jon Meow 946e4fedbc Remove unused args (#153) 2020-09-08 08:41:33 -07:00
Jon Meow 37c1e42b98 Migrate update_label_access to Python, and start consolidating GraphQL logic. (#147)
Main reasons for doing this were:

- Add tests for update_label_access
- Reduce js reliance
- Unify handling of access tokens
- Migrate more to GH's graphql (unfortunately not everything, pygithub is rest-based)
- With pytest, reduce the number of executable scripts
2020-09-03 10:20:54 -07:00
Jon Meow 23d9ae050d Add copyrights to pr_comments (#146) 2020-08-20 09:26:40 -07:00
Jon Meow 63d0b84303 Handle PR reviews. (#134)
The main comment on a review wasn't being handled, and this change interleaves it with the PR comments. GitHub treats these as different entities.

I'm hiding reviews with no top-level comment; these didn't seem worth including empty comments.

Links are being added to PR comments to make them easier to find. This means indenting the content, so now all comments (PR or review thread) are consistently indented, removing a parameter. Also, I'm adjusting the formatting of review threads to match.

snippets for comparison:
```
https://github.com/carbon-language/carbon-lang/pull/83#issuecomment-645573273
  googlebot: All (the pull request submitter and all commit authors) CLAs are...

https://github.com/carbon-language/carbon-lang/pull/83#pullrequestreview-434377138
  chandlerc: Overall, I think this is a pretty significant improved direction...
```

and from a review thread:
```
https://github.com/carbon-language/carbon-lang/pull/83/files/9863da8#diff-8f28081abb21e65fba5a0b0b29404c78R16
  - line 16; unresolved
  - diff: https://github.com/carbon-language/carbon-lang/pull/83/files/9863da8..HEAD#diff-8f28081abb21e65fba5a0b0b29404c78L16
  josh11b: ```suggestion¶ - Block comments begin with a line starting with `/...
  jonmeow: "begin with a line starting with" phrasing is a little confusing t...
  josh11b: As I understand @zygoloid 's lexing proposal, there may be additio...
  jonmeow: Rewritten with example
```
2020-07-31 13:16:15 -07:00
Jon Meow 598283cd5c Link to comments as they are in files. (#133) 2020-07-31 08:24:47 -07:00
Jon Meow 3706d4350d Polish script, address TODOs (#131) 2020-07-30 11:00:08 -07:00