carbon-lang

carbon-language/carbon-lang

Fork 0

mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 21:50:14 +01:00

Commit Graph

Author	SHA1	Message	Date
Jon Meow	8a2ef22c2a	Validate source text size and fix empty buffer bugs. (#1113 ) There's currently a bug with empty files, in that it initializes SourceBuffer with an invalid StringRef that results in a crash. That got me looking at the std::optional TODO, but the issue is that there are really three states: - Buffered - mmapped (not buffered) - Moved out of (no longer initialized) Technically an optional could work if we initialize the buffer on move out, indicating the mmap is gone. But the mode setup felt better to me. And then this also adds the size check. Which is really how I started looking at this.	2022-03-02 13:43:03 -08:00
Jon Meow	b048bb766d	Starting to think about toolchain semantic analysis -- create a trivial shell for it. (#1038 )	2022-01-25 11:06:16 -08:00

Author

SHA1

Message

Date

Jon Meow

8a2ef22c2a

Validate source text size and fix empty buffer bugs. (#1113 )

There's currently a bug with empty files, in that it initializes SourceBuffer with an invalid StringRef that results in a crash. That got me looking at the std::optional TODO, but the issue is that there are really three states:

- Buffered
- mmapped (not buffered)
- Moved out of (no longer initialized)

Technically an optional could work if we initialize the buffer on move out, indicating the mmap is gone. But the mode setup felt better to me.

And then this also adds the size check. Which is really how I started looking at this.

2022-03-02 13:43:03 -08:00

Jon Meow

b048bb766d

Starting to think about toolchain semantic analysis -- create a trivial shell for it. (#1038 )

2022-01-25 11:06:16 -08:00