 Jon Meow
|
63d0b84303
|
Handle PR reviews. (#134)
The main comment on a review wasn't being handled, and this change interleaves it with the PR comments. GitHub treats these as different entities.
I'm hiding reviews with no top-level comment; these didn't seem worth including empty comments.
Links are being added to PR comments to make them easier to find. This means indenting the content, so now all comments (PR or review thread) are consistently indented, removing a parameter. Also, I'm adjusting the formatting of review threads to match.
snippets for comparison:
```
https://github.com/carbon-language/carbon-lang/pull/83#issuecomment-645573273
googlebot: All (the pull request submitter and all commit authors) CLAs are...
https://github.com/carbon-language/carbon-lang/pull/83#pullrequestreview-434377138
chandlerc: Overall, I think this is a pretty significant improved direction...
```
and from a review thread:
```
https://github.com/carbon-language/carbon-lang/pull/83/files/9863da8#diff-8f28081abb21e65fba5a0b0b29404c78R16
- line 16; unresolved
- diff: https://github.com/carbon-language/carbon-lang/pull/83/files/9863da8..HEAD#diff-8f28081abb21e65fba5a0b0b29404c78L16
josh11b: ```suggestion¶ - Block comments begin with a line starting with `/...
jonmeow: "begin with a line starting with" phrasing is a little confusing t...
josh11b: As I understand @zygoloid 's lexing proposal, there may be additio...
jonmeow: Rewritten with example
```
|
2020-07-31 13:16:15 -07:00 |
|