carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Reject/error on base declarations that appear after field declarations (#4553)

Browse Source 
Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
This commit is contained in:
David Blaikie
2024-11-20 23:46:39 +00:00
committed by GitHub
co-authored by Jon Ross-Perkins
parent 16bf3f710e
commit ffbcfc4dfc
5 changed files with 153 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/handle_class.cpp
+9
View File
@@ -512,6 +512,15 @@ auto HandleParseNode(Context& context, Parse::BaseDeclId node_id) -> bool {
return true;
}
if (!context.struct_type_fields_stack().PeekArray().empty()) {
// TODO: Add note that includes the first field location as an example.
CARBON_DIAGNOSTIC(
BaseDeclAfterFieldDecl, Error,
"`base` declaration must appear before field declarations");
context.emitter().Emit(node_id, BaseDeclAfterFieldDecl);
return true;
}
auto base_info = CheckBaseType(context, base_type_node_id, base_type_expr_id);
// The `base` value in the class scope has an unbound element type. Instance