carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 10:54:49 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add underscores to private data members (#898)

Browse Source 
This is the last PR I plan to have focused on #720
This commit is contained in:
Jon Meow
2021-10-19 14:27:10 -07:00
committed by GitHub
parent dc9c36660b
commit ffa4e76ede
17 changed files with 363 additions and 356 deletions
Download Patch File Download Diff File Expand all files Collapse all files
executable_semantics/interpreter/field_path.h
+5 -5
View File
@@ -30,7 +30,7 @@ class FieldPath {
FieldPath() = default;
// Constructs a FieldPath consisting of a single step.
explicit FieldPath(std::string name) : components({std::move(name)}) {}
explicit FieldPath(std::string name) : components_({std::move(name)}) {}
FieldPath(const FieldPath&) = default;
FieldPath(FieldPath&&) = default;
@@ -38,15 +38,15 @@ class FieldPath {
auto operator=(FieldPath&&) -> FieldPath& = default;
// Returns whether *this is empty.
auto IsEmpty() const -> bool { return components.empty(); }
auto IsEmpty() const -> bool { return components_.empty(); }
// Appends `name` to the end of *this.
auto Append(std::string name) -> void {
components.push_back(std::move(name));
components_.push_back(std::move(name));
}
void Print(llvm::raw_ostream& out) const {
for (const std::string& component : components) {
for (const std::string& component : components_) {
out << "." << component;
}
}
@@ -58,7 +58,7 @@ class FieldPath {
// another Value, so its implementation details are tied to the implementation
// details of Value.
friend class Value;
std::vector<std::string> components;
std::vector<std::string> components_;
};
} // namespace Carbon