carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Implement "unused pattern bindings" p2022 - parsing (#6460)

Browse Source 
This implements proposal #2022, with changes from #3763 and leads
answers on #6448

Detection of unusedness is happening in
~~`toolchain/check/dataflow_analysis.cpp`~~ next PR. See
[here](https://github.com/burakemir/carbon-lang/tree/unused_pattern_bindings_p2022_impl_part2)
for preview.

~~All test cases with unused bindings were updated in order to avoid
polluting test output.~~

---------

Co-authored-by: Dana Jansens <danakj@orodu.net>
This commit is contained in:
Burak Emir
2025-12-17 15:40:20 +00:00
committed by GitHub
co-authored by Dana Jansens
parent ad7ea755b0
commit fec6ce2f9f
16 changed files with 851 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/handle_pattern_list.cpp
+10 -5
View File
@@ -12,8 +12,10 @@ static auto HandlePatternListElement(Context& context, StateKind pattern_state,
StateKind finish_state_kind) -> void {
auto state = context.PopState();
context.PushStateForPattern(finish_state_kind, state.in_var_pattern);
context.PushStateForPattern(pattern_state, state.in_var_pattern);
context.PushStateForPattern(finish_state_kind, state.in_var_pattern,
state.in_unused_pattern);
context.PushStateForPattern(pattern_state, state.in_var_pattern,
state.in_unused_pattern);
}
auto HandlePatternListElementAsTuple(Context& context) -> void {
@@ -44,7 +46,8 @@ static auto HandlePatternListElementFinish(Context& context,
if (context.ConsumeListToken(NodeKind::PatternListComma, close_token,
state.has_error) ==
Context::ListTokenKind::Comma) {
context.PushStateForPattern(param_state_kind, state.in_var_pattern);
context.PushStateForPattern(param_state_kind, state.in_var_pattern,
state.in_unused_pattern);
}
}
@@ -71,11 +74,13 @@ static auto HandlePatternList(Context& context, NodeKind node_kind,
-> void {
auto state = context.PopState();
context.PushStateForPattern(finish_state, state.in_var_pattern);
context.PushStateForPattern(finish_state, state.in_var_pattern,
state.in_unused_pattern);
context.AddLeafNode(node_kind, context.ConsumeChecked(open_token_kind));
if (!context.PositionIs(close_token_kind)) {
context.PushStateForPattern(param_state, state.in_var_pattern);
context.PushStateForPattern(param_state, state.in_var_pattern,
state.in_unused_pattern);
}
}