carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Implement unused pattern bindings, continued (#6518)

Browse Source 
Implementation of unused pattern bindings #2022, continued.

Whereas previous PR #6460 took care of parsing, and PR #6479 prepared
the stage by using _ in some test cases, this PR has the the actual
implementation, using a simple dataflow analysis.

---------

Co-authored-by: Burak Emir <bqe@google.com>
Co-authored-by: jonmeow <jperkins@google.com>
This commit is contained in:
Burak Emir
2026-02-19 23:33:36 +00:00
committed by GitHub
co-authored by Burak Emir jonmeow
parent bea24a8bee
commit fdb188ccfd
366 changed files with 8453 additions and 7996 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/testdata/impl/impl.carbon
Vendored
+14 -14
View File
@@ -45,21 +45,21 @@ interface I(T:! type) {
}
impl C as I(A) {
fn F[self: C]() -> A { return {}; }
fn F[unused self: C]() -> A { return {}; }
}
impl C as I(B) {
fn F[self: C]() -> B { return {}; }
fn F[unused self: C]() -> B { return {}; }
}
fn F1(x: C, y: C) {
var a: A = x.(I(A).F)();
var b: B = y.(I(B).F)();
var unused a: A = x.(I(A).F)();
var unused b: B = y.(I(B).F)();
}
fn F2[T:! I(A), U:! I(B)](x: T, y: U) {
var a: A = x.F();
var b: B = y.F();
var unused a: A = x.F();
var unused b: B = y.F();
}
// --- generic_class_impls.carbon
@@ -127,20 +127,20 @@ impl C(B) as I {
// CHECK:STDOUT: ; ModuleID = 'generic_impls.carbon'
// CHECK:STDOUT: source_filename = "generic_impls.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: @A.val.loc13_35 = internal constant {} zeroinitializer
// CHECK:STDOUT: @B.val.loc17_35 = internal constant {} zeroinitializer
// CHECK:STDOUT: @A.val.loc13_42 = internal constant {} zeroinitializer
// CHECK:STDOUT: @B.val.loc17_42 = internal constant {} zeroinitializer
// CHECK:STDOUT:
// CHECK:STDOUT: ; Function Attrs: nounwind
// CHECK:STDOUT: define void @"_CF.C.Main:I.96947bccc1c5e61b.Main"(ptr sret({}) %return, ptr %self) #0 !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @A.val.loc13_35, i64 0, i1 false), !dbg !10
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @A.val.loc13_42, i64 0, i1 false), !dbg !10
// CHECK:STDOUT: ret void, !dbg !10
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: ; Function Attrs: nounwind
// CHECK:STDOUT: define void @"_CF.C.Main:I.707dbe5ae2414d29.Main"(ptr sret({}) %return, ptr %self) #0 !dbg !11 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @B.val.loc17_35, i64 0, i1 false), !dbg !14
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @B.val.loc17_42, i64 0, i1 false), !dbg !14
// CHECK:STDOUT: ret void, !dbg !14
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -183,11 +183,11 @@ impl C(B) as I {
// CHECK:STDOUT: !7 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: null, size: 8)
// CHECK:STDOUT: !8 = !{!9}
// CHECK:STDOUT: !9 = !DILocalVariable(arg: 1, scope: !4, type: !7)
// CHECK:STDOUT: !10 = !DILocation(line: 13, column: 26, scope: !4)
// CHECK:STDOUT: !10 = !DILocation(line: 13, column: 33, scope: !4)
// CHECK:STDOUT: !11 = distinct !DISubprogram(name: "F", linkageName: "_CF.C.Main:I.707dbe5ae2414d29.Main", scope: null, file: !3, line: 17, type: !5, spFlags: DISPFlagDefinition, unit: !2, retainedNodes: !12)
// CHECK:STDOUT: !12 = !{!13}
// CHECK:STDOUT: !13 = !DILocalVariable(arg: 1, scope: !11, type: !7)
// CHECK:STDOUT: !14 = !DILocation(line: 17, column: 26, scope: !11)
// CHECK:STDOUT: !14 = !DILocation(line: 17, column: 33, scope: !11)
// CHECK:STDOUT: !15 = distinct !DISubprogram(name: "F1", linkageName: "_CF1.Main", scope: null, file: !3, line: 20, type: !16, spFlags: DISPFlagDefinition, unit: !2, retainedNodes: !18)
// CHECK:STDOUT: !16 = !DISubroutineType(types: !17)
// CHECK:STDOUT: !17 = !{null, !7, !7}
@@ -196,8 +196,8 @@ impl C(B) as I {
// CHECK:STDOUT: !20 = !DILocalVariable(arg: 2, scope: !15, type: !7)
// CHECK:STDOUT: !21 = !DILocation(line: 21, column: 3, scope: !15)
// CHECK:STDOUT: !22 = !DILocation(line: 22, column: 3, scope: !15)
// CHECK:STDOUT: !23 = !DILocation(line: 21, column: 14, scope: !15)
// CHECK:STDOUT: !24 = !DILocation(line: 22, column: 14, scope: !15)
// CHECK:STDOUT: !23 = !DILocation(line: 21, column: 21, scope: !15)
// CHECK:STDOUT: !24 = !DILocation(line: 22, column: 21, scope: !15)
// CHECK:STDOUT: !25 = !DILocation(line: 20, column: 1, scope: !15)
// CHECK:STDOUT: ; ModuleID = 'generic_class_impls.carbon'
// CHECK:STDOUT: source_filename = "generic_class_impls.carbon"
toolchain/lower/testdata/impl/import_facet.carbon
Vendored
+3 -3
View File
@@ -17,7 +17,7 @@
library "[[@TEST_NAME]]";
class C(T:! Core.Copy & Core.Destroy) {
fn GetC[self: Self]() -> T {
fn GetC[unused self: Self]() -> T {
var value: T;
return value;
}
@@ -29,7 +29,7 @@ export import library "a";
interface I {
let T:! Core.Copy & Core.Destroy;
fn GetI[self: Self]() -> C(T);
fn GetI[unused self: Self]() -> C(T);
}
// --- c.carbon
@@ -38,7 +38,7 @@ export import library "b";
class D(T:! type) {
impl as I where .T = T* {
fn GetI[self: Self]() -> C(T*) {
fn GetI[unused self: Self]() -> C(T*) {
return {};
}
}
toolchain/lower/testdata/impl/thunk.carbon
Vendored
+15 -15
View File
@@ -44,7 +44,7 @@ library "[[@TEST_NAME]]";
class A {}
class B {
impl as Core.ImplicitAs(A) {
fn Convert[self: Self]() -> A { return {}; }
fn Convert[unused self: Self]() -> A { return {}; }
}
}
@@ -55,7 +55,7 @@ interface I(T:! type) {
class C(U:! type) {}
impl forall [V:! type] C(V) as I(V) {
fn F[self: Self](_: A) -> B { return {}; }
fn F[unused self: Self](_: A) -> B { return {}; }
}
fn Call(c: C(()), b: B) -> A {
@@ -183,13 +183,13 @@ fn CallCallGeneric(c: C(()), b: B) -> A {
// CHECK:STDOUT: ; ModuleID = 'generic_thunk.carbon'
// CHECK:STDOUT: source_filename = "generic_thunk.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: @A.val.loc7_46 = internal constant {} zeroinitializer
// CHECK:STDOUT: @B.val.loc18_42 = internal constant {} zeroinitializer
// CHECK:STDOUT: @A.val.loc7_53 = internal constant {} zeroinitializer
// CHECK:STDOUT: @B.val.loc18_49 = internal constant {} zeroinitializer
// CHECK:STDOUT:
// CHECK:STDOUT: ; Function Attrs: nounwind
// CHECK:STDOUT: define void @"_CConvert.B.Main:ImplicitAs.96947bccc1c5e61b.Core"(ptr sret({}) %return, ptr %self) #0 !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @A.val.loc7_46, i64 0, i1 false), !dbg !10
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @A.val.loc7_53, i64 0, i1 false), !dbg !10
// CHECK:STDOUT: ret void, !dbg !10
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -227,7 +227,7 @@ fn CallCallGeneric(c: C(()), b: B) -> A {
// CHECK:STDOUT: ; Function Attrs: nounwind
// CHECK:STDOUT: define linkonce_odr void @"_CF.C.eb057aa32837c84e.Main:I.eb057aa32837c84e.Main.e43630e9a6c38c3f"(ptr sret({}) %return, ptr %self, ptr %_) #0 !dbg !26 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @B.val.loc18_42, i64 0, i1 false), !dbg !30
// CHECK:STDOUT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 %return, ptr align 1 @B.val.loc18_49, i64 0, i1 false), !dbg !30
// CHECK:STDOUT: ret void, !dbg !30
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -241,16 +241,16 @@ fn CallCallGeneric(c: C(()), b: B) -> A {
// CHECK:STDOUT: ; Function Attrs: alwaysinline nounwind
// CHECK:STDOUT: define linkonce_odr void @"_CF:thunk.C.eb057aa32837c84e.Main:I.eb057aa32837c84e.Main.e43630e9a6c38c3f"(ptr sret({}) %return, ptr %self, ptr %x) #3 !dbg !37 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: %.loc18_31.2.temp = alloca {}, align 8, !dbg !41
// CHECK:STDOUT: %.loc18_31.6.temp = alloca {}, align 8, !dbg !41
// CHECK:STDOUT: %.loc18_38.2.temp = alloca {}, align 8, !dbg !41
// CHECK:STDOUT: %.loc18_38.6.temp = alloca {}, align 8, !dbg !41
// CHECK:STDOUT: %.loc12_21.1.temp = alloca {}, align 8, !dbg !42
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %.loc18_31.2.temp), !dbg !41
// CHECK:STDOUT: call void @"_CConvert.B.Main:ImplicitAs.96947bccc1c5e61b.Core"(ptr %.loc18_31.2.temp, ptr %x), !dbg !41
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %.loc18_31.6.temp), !dbg !41
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %.loc18_38.2.temp), !dbg !41
// CHECK:STDOUT: call void @"_CConvert.B.Main:ImplicitAs.96947bccc1c5e61b.Core"(ptr %.loc18_38.2.temp, ptr %x), !dbg !41
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %.loc18_38.6.temp), !dbg !41
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %.loc12_21.1.temp), !dbg !42
// CHECK:STDOUT: call void @"_CConvert.B.Main:ImplicitAs.96947bccc1c5e61b.Core"(ptr %.loc12_21.1.temp, ptr %x), !dbg !42
// CHECK:STDOUT: call void @"_CF.C.eb057aa32837c84e.Main:I.eb057aa32837c84e.Main.e43630e9a6c38c3f"(ptr %.loc18_31.6.temp, ptr %self, ptr %.loc12_21.1.temp), !dbg !41
// CHECK:STDOUT: call void @"_CConvert.B.Main:ImplicitAs.96947bccc1c5e61b.Core"(ptr %return, ptr %.loc18_31.6.temp), !dbg !41
// CHECK:STDOUT: call void @"_CF.C.eb057aa32837c84e.Main:I.eb057aa32837c84e.Main.e43630e9a6c38c3f"(ptr %.loc18_38.6.temp, ptr %self, ptr %.loc12_21.1.temp), !dbg !41
// CHECK:STDOUT: call void @"_CConvert.B.Main:ImplicitAs.96947bccc1c5e61b.Core"(ptr %return, ptr %.loc18_38.6.temp), !dbg !41
// CHECK:STDOUT: ret void, !dbg !41
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -275,7 +275,7 @@ fn CallCallGeneric(c: C(()), b: B) -> A {
// CHECK:STDOUT: !7 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: null, size: 8)
// CHECK:STDOUT: !8 = !{!9}
// CHECK:STDOUT: !9 = !DILocalVariable(arg: 1, scope: !4, type: !7)
// CHECK:STDOUT: !10 = !DILocation(line: 7, column: 37, scope: !4)
// CHECK:STDOUT: !10 = !DILocation(line: 7, column: 44, scope: !4)
// CHECK:STDOUT: !11 = distinct !DISubprogram(name: "Call", linkageName: "_CCall.Main", scope: null, file: !3, line: 21, type: !12, spFlags: DISPFlagDefinition, unit: !2, retainedNodes: !14)
// CHECK:STDOUT: !12 = !DISubroutineType(types: !13)
// CHECK:STDOUT: !13 = !{!7, !7, !7}
@@ -295,7 +295,7 @@ fn CallCallGeneric(c: C(()), b: B) -> A {
// CHECK:STDOUT: !27 = !{!28, !29}
// CHECK:STDOUT: !28 = !DILocalVariable(arg: 1, scope: !26, type: !7)
// CHECK:STDOUT: !29 = !DILocalVariable(arg: 2, scope: !26, type: !7)
// CHECK:STDOUT: !30 = !DILocation(line: 18, column: 33, scope: !26)
// CHECK:STDOUT: !30 = !DILocation(line: 18, column: 40, scope: !26)
// CHECK:STDOUT: !31 = distinct !DISubprogram(name: "CallGeneric", linkageName: "_CCallGeneric.Main.0bac38e8a17f7a1f", scope: null, file: !3, line: 25, type: !12, spFlags: DISPFlagDefinition, unit: !2, retainedNodes: !32)
// CHECK:STDOUT: !32 = !{!33, !34}
// CHECK:STDOUT: !33 = !DILocalVariable(arg: 1, scope: !31, type: !7)