Implement unused pattern bindings, continued (#6518)

Implementation of unused pattern bindings #2022, continued.

Whereas previous PR #6460 took care of parsing, and PR #6479 prepared
the stage by using _ in some test cases, this PR has the the actual
implementation, using a simple dataflow analysis.

---------

Co-authored-by: Burak Emir <bqe@google.com>
Co-authored-by: jonmeow <jperkins@google.com>
This commit is contained in:
Burak Emir
2026-02-19 23:33:36 +00:00
committed by GitHub
co-authored by Burak Emir jonmeow
parent bea24a8bee
commit fdb188ccfd
366 changed files with 8453 additions and 7996 deletions
+11 -11
View File
@@ -14,8 +14,8 @@
library "[[@TEST_NAME]]";
fn Basic(n: i32) {}
eval fn Eval(n: i32) {}
fn Basic(unused n: i32) {}
eval fn Eval(unused n: i32) {}
fn RuntimeArg(n: i32) {
Basic(n);
@@ -26,15 +26,15 @@ fn RuntimeArg(n: i32) {
library "[[@TEST_NAME]]";
musteval fn MustEval(n: i32) {}
musteval fn MustEval(unused n: i32) {}
fn RuntimeArg(n: i32) {
// CHECK:STDERR: fail_no_eval_musteval.carbon:[[@LINE+7]]:3: error: non-constant call to compile-time-only function [NonConstantCallToCompTimeOnlyFunction]
// CHECK:STDERR: MustEval(n);
// CHECK:STDERR: ^~~~~~~~~~~
// CHECK:STDERR: fail_no_eval_musteval.carbon:[[@LINE-6]]:1: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
// CHECK:STDERR: musteval fn MustEval(n: i32) {}
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR: musteval fn MustEval(unused n: i32) {}
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR:
MustEval(n);
}
@@ -43,9 +43,9 @@ fn RuntimeArg(n: i32) {
library "[[@TEST_NAME]]";
fn Basic(n: i32) {}
eval fn Eval(n: i32) {}
musteval fn MustEval(n: i32) {}
fn Basic(unused n: i32) {}
eval fn Eval(unused n: i32) {}
musteval fn MustEval(unused n: i32) {}
fn CompileTimeArg() {
Basic(1);
@@ -57,7 +57,7 @@ fn CompileTimeArg() {
library "[[@TEST_NAME]]";
musteval fn MustEval(n: i32) {}
musteval fn MustEval(unused n: i32) {}
// TODO: This should be accepted.
musteval fn CallMustEval(n: i32) {
@@ -65,8 +65,8 @@ musteval fn CallMustEval(n: i32) {
// CHECK:STDERR: MustEval(n);
// CHECK:STDERR: ^~~~~~~~~~~
// CHECK:STDERR: fail_todo_musteval_calls_musteval.carbon:[[@LINE-7]]:1: note: compile-time-only function declared here [CompTimeOnlyFunctionHere]
// CHECK:STDERR: musteval fn MustEval(n: i32) {}
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR: musteval fn MustEval(unused n: i32) {}
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR:
MustEval(n);
}