carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Implement unused pattern bindings, continued (#6518)

Browse Source 
Implementation of unused pattern bindings #2022, continued.

Whereas previous PR #6460 took care of parsing, and PR #6479 prepared
the stage by using _ in some test cases, this PR has the the actual
implementation, using a simple dataflow analysis.

---------

Co-authored-by: Burak Emir <bqe@google.com>
Co-authored-by: jonmeow <jperkins@google.com>
This commit is contained in:
Burak Emir
2026-02-19 23:33:36 +00:00
committed by GitHub
co-authored by Burak Emir jonmeow
parent bea24a8bee
commit fdb188ccfd
366 changed files with 8453 additions and 7996 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/merge.cpp
+13 -2
View File
@@ -450,12 +450,23 @@ static auto CheckRedeclParamSyntax(Context& context,
for (; new_iter != new_end && prev_iter != prev_end;
++new_iter, ++prev_iter) {
auto new_node_id = *new_iter;
auto new_node_kind = context.parse_tree().node_kind(new_node_id);
// Skip over "unused" markers.
if (new_node_kind == Parse::NodeKind::UnusedPattern) {
++new_iter;
new_node_id = *new_iter;
new_node_kind = context.parse_tree().node_kind(new_node_id);
}
auto prev_node_id = *prev_iter;
auto prev_node_kind = context.parse_tree().node_kind(prev_node_id);
if (prev_node_kind == Parse::NodeKind::UnusedPattern) {
++prev_iter;
prev_node_id = *prev_iter;
prev_node_kind = context.parse_tree().node_kind(prev_node_id);
}
if (!IsNodeSyntaxEqual(context, new_node_id, prev_node_id)) {
// Skip difference if it is `Self as` vs. `as` in an `impl` declaration.
// https://github.com/carbon-language/carbon-lang/blob/trunk/proposals/p3763.md#redeclarations
auto new_node_kind = context.parse_tree().node_kind(new_node_id);
auto prev_node_kind = context.parse_tree().node_kind(prev_node_id);
if (new_node_kind == Parse::NodeKind::ImplDefaultSelfAs &&
prev_node_kind == Parse::NodeKind::SelfTypeNameExpr &&
context.parse_tree().node_kind(prev_iter[1]) ==