Don't return SemanticsFunction by value. (#2968)

It contains a vector, so it's not cheap to copy. Return by const
reference instead.

Thanks to @fasiddique for spotting this!
This commit is contained in:
Richard Smith authored and GitHub committed 2023-07-05 22:09:50 +00:00
1 parent 3c7bca4115
commit f992d4d960
3 files changed
+4 -3

No files matched your search

@@ -22,7 +22,7 @@ auto SemanticsHandleReturnStatement(SemanticsContext& context,
CARBON_CHECK(!context.return_scope_stack().empty());
const auto& fn_node =
context.semantics_ir().GetNode(context.return_scope_stack().back());
const auto callable =
const auto& callable =
context.semantics_ir().GetFunction(fn_node.GetAsFunctionDeclaration());
if (context.parse_tree().node_kind(context.node_stack().PeekParseNode()) ==