carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 10:31:03 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Don't return SemanticsFunction by value. (#2968)

Browse Source 
It contains a vector, so it's not cheap to copy. Return by const
reference instead.

Thanks to @fasiddique for spotting this!
This commit is contained in:
Richard Smith
2023-07-05 22:09:50 +00:00
committed by GitHub
parent 3c7bca4115
commit f992d4d960
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_handle_statement.cpp
+1 -1
View File
@@ -22,7 +22,7 @@ auto SemanticsHandleReturnStatement(SemanticsContext& context,
CARBON_CHECK(!context.return_scope_stack().empty());
const auto& fn_node =
context.semantics_ir().GetNode(context.return_scope_stack().back());
const auto callable =
const auto& callable =
context.semantics_ir().GetFunction(fn_node.GetAsFunctionDeclaration());
if (context.parse_tree().node_kind(context.node_stack().PeekParseNode()) ==