Don't return SemanticsFunction by value. (#2968)

It contains a vector, so it's not cheap to copy. Return by const
reference instead.

Thanks to @fasiddique for spotting this!
This commit is contained in:
Richard Smith authored and GitHub committed 2023-07-05 22:09:50 +00:00
1 parent 3c7bca4115
commit f992d4d960
3 files changed
+4 -3

No files matched your search

@@ -24,7 +24,7 @@ auto SemanticsHandleCallExpression(SemanticsContext& context,
}
auto function_id = name_node.GetAsFunctionDeclaration();
auto callable = context.semantics_ir().GetFunction(function_id);
const auto& callable = context.semantics_ir().GetFunction(function_id);
CARBON_DIAGNOSTIC(NoMatchingCall, Error, "No matching callable was found.");
auto diagnostic =