carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 06:41:06 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Only export each class or namespace to C++ once. (#7042)

Browse Source 
Instead of exporting a class or namespace each time a new C++ name
lookup discovers it, track that we have exported the entity on its name
scope, and if a new name lookup finds the same entity, produce the same
clang declaration.
This commit is contained in:
Richard Smith
2026-04-13 19:43:44 +00:00
committed by GitHub
parent 3cdb159067
commit f31e1685fd
11 changed files with 325 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/interop/cpp/namespace/export.carbon
Vendored
+30
View File
@@ -0,0 +1,30 @@
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/namespace/export.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/namespace/export.carbon
// --- alias_identity.carbon
import Cpp;
namespace M;
alias N = M;
class M.C {}
inline Cpp '''
// OK, valid redeclaration: M and N are the same namespace.
namespace A = Carbon::M;
namespace A = Carbon::N;
// Valid: M::C and N::C are the same class.
Carbon::M::C *pmc;
Carbon::N::C *pnc = pmc;
''';
toolchain/check/testdata/interop/cpp/namespace/basic.carbon → toolchain/check/testdata/interop/cpp/namespace/import.carbon
Vendored
+2 -2
View File
@@ -6,9 +6,9 @@
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/namespace/basic.carbon
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/namespace/import.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/namespace/basic.carbon
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/namespace/import.carbon
// ============================================================================
// Single
toolchain/check/testdata/interop/cpp/namespace/roundtrip.carbon
Vendored
+4 -4
View File
@@ -81,16 +81,16 @@ library "[[@TEST_NAME]]";
import Cpp;
// CHECK:STDERR: fail_carbon_raw_cpp.carbon:[[@LINE+4]]:7: error: semantics TODO: `interop with non-identifier package name` [SemanticsTodo]
// CHECK:STDERR: alias r#Cpp = Cpp;
// CHECK:STDERR: ^~~
// CHECK:STDERR:
alias r#Cpp = Cpp;
inline Cpp '''
void F();
void G() {
// CHECK:STDERR: fail_carbon_raw_cpp.carbon:[[@LINE+8]]:16: error: semantics TODO: `interop with translation unit decl` [SemanticsTodo]
// CHECK:STDERR: Carbon::Cpp::F();
// CHECK:STDERR: ^
// CHECK:STDERR:
// CHECK:STDERR: fail_carbon_raw_cpp.carbon:[[@LINE+4]]:11: error: no member named 'Cpp' in namespace 'Carbon' [CppInteropParseError]
// CHECK:STDERR: 19 | Carbon::Cpp::F();
// CHECK:STDERR: | ~~~~~~~~^