carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-25 11:50:13 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Refactor FunctionDefinition towards instance methods (#654)

Browse Source 
It felt weird to have a `Make` method in this case.
This commit is contained in:
Jon Meow
2021-07-15 14:55:44 -07:00
committed by GitHub
parent d2afd45214
commit ef785bb6e3
5 changed files with 28 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
executable_semantics/ast/function_definition.cpp
+6 -20
View File
@@ -8,32 +8,18 @@
namespace Carbon {
auto MakeFunDef(int line_num, std::string name, const Expression* ret_type,
const Expression* param_pattern, const Statement* body)
-> FunctionDefinition {
FunctionDefinition f;
f.line_num = line_num;
f.name = std::move(name);
f.return_type = ret_type;
f.param_pattern = param_pattern;
f.body = body;
return f;
}
void PrintFunDefDepth(const FunctionDefinition& f, int depth) {
std::cout << "fn " << f.name << " ";
PrintExp(f.param_pattern);
void FunctionDefinition::PrintDepth(int depth) const {
std::cout << "fn " << name << " ";
PrintExp(param_pattern);
std::cout << " -> ";
PrintExp(f.return_type);
if (f.body) {
PrintExp(return_type);
if (body) {
std::cout << " {" << std::endl;
PrintStatement(f.body, depth);
PrintStatement(body, depth);
std::cout << std::endl << "}" << std::endl;
} else {
std::cout << ";" << std::endl;
}
}
void PrintFunDef(const FunctionDefinition& f) { PrintFunDefDepth(f, -1); }
} // namespace Carbon