From edc6ed3d102129a859687b34dd0c8f5a6b21ddf7 Mon Sep 17 00:00:00 2001 From: Jon Ross-Perkins Date: Mon, 23 Sep 2024 15:18:10 -0700 Subject: [PATCH] Clean up comment about node ID. (#4335) Without researching, I think this just predates the templating. Also refactoring the body since there's not really a benefit to having each line be its own expression, and the `arg.loc_id.node_id()` is a little indirect when `node_id` is an argument. --- toolchain/check/context.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/toolchain/check/context.h b/toolchain/check/context.h index 1d4a31e7e348..5a7924846dca 100644 --- a/toolchain/check/context.h +++ b/toolchain/check/context.h @@ -130,14 +130,12 @@ class Context { auto AddConstant(SemIR::Inst inst, bool is_symbolic) -> SemIR::ConstantId; // Pushes a parse tree node onto the stack, storing the SemIR::Inst as the - // result. Only valid if the LocId is for a NodeId. + // result. template requires(SemIR::Internal::HasNodeId) auto AddInstAndPush(decltype(InstT::Kind)::TypedNodeId node_id, InstT inst) -> void { - SemIR::LocIdAndInst arg(node_id, inst); - auto inst_id = AddInst(arg); - node_stack_.Push(arg.loc_id.node_id(), inst_id); + node_stack_.Push(node_id, AddInst(node_id, inst)); } // Replaces the instruction `inst_id` with `loc_id_and_inst`. The instruction