carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-25 20:50:12 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Note namespace and static recommendations in C++ style guide (#1041)

Browse Source
This commit is contained in:
Jon Meow
2022-01-27 11:26:47 -08:00
committed by GitHub
parent 086834d63a
commit eda43faa5a
16 changed files with 48 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/string_helpers.cpp
+4 -8
View File
@@ -13,13 +13,11 @@
namespace Carbon {
namespace {
constexpr llvm::StringRef TripleQuotes = "\"\"\"";
constexpr llvm::StringRef HorizontalWhitespaceChars = " \t";
static constexpr llvm::StringRef TripleQuotes = "\"\"\"";
static constexpr llvm::StringRef HorizontalWhitespaceChars = " \t";
// Carbon only takes uppercase hex input.
auto FromHex(char c) -> std::optional<char> {
static auto FromHex(char c) -> std::optional<char> {
if (c >= '0' && c <= '9') {
return c - '0';
}
@@ -30,12 +28,10 @@ auto FromHex(char c) -> std::optional<char> {
}
// Creates an error instance with the specified `message`.
llvm::Expected<std::string> MakeError(llvm::Twine message) {
static auto MakeError(llvm::Twine message) -> llvm::Expected<std::string> {
return llvm::createStringError(llvm::inconvertibleErrorCode(), message);
}
} // namespace
auto UnescapeStringLiteral(llvm::StringRef source, bool is_block_string)
-> std::optional<std::string> {
std::string ret;