Allow unknown fields in fuzzing text proto (#1296)

This is to help with frequent build breakages cased by proto changes.
Fuzzer corpus can be periodically auto-regenerated.
Crashing samples from the fuzzer are better 'preserved' in the form of fail_xx.carbon tests.
This commit is contained in:
pk19604014
2022-05-25 15:44:06 -07:00
committed by GitHub
parent 5d184a4828
commit ed93d95fce
4 changed files with 45 additions and 11 deletions
+22 -6
View File
@@ -5,7 +5,6 @@
#include "explorer/fuzzing/fuzzer_util.h"
#include <gmock/gmock.h>
#include <google/protobuf/text_format.h>
#include <gtest/gtest.h>
#include <fstream>
@@ -27,11 +26,10 @@ TEST(FuzzerUtilTest, RunFuzzerOnCorpus) {
ASSERT_TRUE(file.is_open());
std::stringstream contents;
contents << file.rdbuf();
Fuzzing::Carbon carbon_proto;
ASSERT_TRUE(google::protobuf::TextFormat::ParseFromString(contents.str(),
&carbon_proto))
<< " couldn't parse text proto in " << f;
ParseAndExecute(carbon_proto.compilation_unit());
const ErrorOr<Fuzzing::Carbon> carbon_proto =
ParseCarbonTextProto(contents.str());
ASSERT_TRUE(carbon_proto.ok()) << "couldn't parse text proto in " << f;
ParseAndExecute(carbon_proto->compilation_unit());
++file_count;
}
EXPECT_GT(file_count, 0);
@@ -45,6 +43,24 @@ TEST(FuzzerUtilTest, GetRunfilesFile) {
testing::EndsWith("doesn't exist"));
}
TEST(FuzzerUtilTest, ParseCarbonTextProtoWithUnknownField) {
const ErrorOr<Fuzzing::Carbon> carbon_proto =
ParseCarbonTextProto(R"(
compilation_unit {
garbage: "value"
declarations {
choice {
name: "Ch"
}
}
})",
/*allow_unknown=*/true);
ASSERT_TRUE(carbon_proto.ok());
// No EqualsProto in gmock - https://github.com/google/googletest/issues/1761.
EXPECT_EQ(carbon_proto->compilation_unit().declarations(0).choice().name(),
"Ch");
}
} // namespace
} // namespace Carbon::Testing