carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Track complete types required by a generic. (#4652)

Browse Source 
When a generic requires a symbolic type to be complete, add a new
`require_complete_type` instruction to the generic eval block. During
monomorphization of such an instruction, require that type to be
complete.
This commit is contained in:
Richard Smith
2024-12-10 03:00:28 +00:00
committed by GitHub
parent e75ef34591
commit eabe9f117a
107 changed files with 1357 additions and 291 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/eval.cpp
+41
View File
@@ -1768,6 +1768,47 @@ static auto TryEvalInstInContext(EvalContext& eval_context,
return MakeConstantResult(eval_context.context(), typed_inst, phase);
}
case CARBON_KIND(SemIR::RequireCompleteType require_complete): {
auto phase = Phase::Template;
auto witness_type_id = eval_context.context().GetSingletonType(
SemIR::WitnessType::SingletonInstId);
auto complete_type_id = GetConstantValue(
eval_context, require_complete.complete_type_id, &phase);
// If the type is a template constant, require it to be complete now.
if (phase == Phase::Template) {
// No location is needed here because we know the type is not a symbolic
// constant.
complete_type_id = eval_context.context().AsCompleteType(
complete_type_id, SemIR::LocId::Invalid, [&] {
CARBON_DIAGNOSTIC(IncompleteTypeInMonomorphization, Error,
"{0} evaluates to incomplete type {1}",
SemIR::TypeId, SemIR::TypeId);
return eval_context.emitter().Build(
inst_id, IncompleteTypeInMonomorphization,
require_complete.complete_type_id, complete_type_id);
});
if (complete_type_id == SemIR::ErrorInst::SingletonTypeId) {
return SemIR::ErrorInst::SingletonConstantId;
}
return MakeConstantResult(
eval_context.context(),
SemIR::CompleteTypeWitness{
.type_id = witness_type_id,
.object_repr_id =
eval_context.types().GetObjectRepr(complete_type_id)},
phase);
}
// If it's not a template constant, require it to be complete once it
// becomes one.
return MakeConstantResult(
eval_context.context(),
SemIR::RequireCompleteType{.type_id = witness_type_id,
.complete_type_id = complete_type_id},
phase);
}
// These cases are either not expressions or not constant.
case SemIR::AddrPattern::Kind:
case SemIR::Assign::Kind: