carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Track the file kind on SourceLocation rather than computing it from the file name. (#2999)

Browse Source 
This will be more correct if a user file is named prelude.carbon, and
reduces the explorer runtime by about 10% by removing a string
comparison from the check for whether trace output is enabled.

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
This commit is contained in:
Richard Smith
2023-07-19 23:07:53 +00:00
committed by GitHub
co-authored by Jon Ross-Perkins
parent 41e357492b
commit ea60e4f491
29 changed files with 168 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/interpreter/action_stack.cpp
+6 -2
View File
@@ -275,8 +275,10 @@ void ActionStack::PushCleanUpActions(
while (!actions.empty()) {
auto& act = actions.top();
if (act->scope()) {
// TODO: Provide a real source location.
std::unique_ptr<Action> cleanup_action = std::make_unique<CleanUpAction>(
std::move(*act->scope()), SourceLocation("stack cleanup", 1));
std::move(*act->scope()),
SourceLocation("stack cleanup", 1, FileKind::Unknown));
todo_.Push(std::move(cleanup_action));
}
actions.pop();
@@ -286,8 +288,10 @@ void ActionStack::PushCleanUpActions(
void ActionStack::PushCleanUpAction(std::unique_ptr<Action> act) {
auto& scope = act->scope();
if (scope && act->kind() != Action::Kind::CleanUpAction) {
// TODO: Provide a real source location.
std::unique_ptr<Action> cleanup_action = std::make_unique<CleanUpAction>(
std::move(*scope), SourceLocation("stack cleanup", 1));
std::move(*scope),
SourceLocation("stack cleanup", 1, FileKind::Unknown));
todo_.Push(std::move(cleanup_action));
}
}