carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Abbreviate "representation" -> "repr" (#3464)

Browse Source 
Specifically using these abbreviations:
* InitRepr: "initializing representation"
* ObjectRepr: "object representation"
* ValueRepr: "value representation"

As discussed in [#toolchain
discord](https://discord.com/channels/655572317891461132/655578254970716160/1182086098470572143)
and now documented in the [list of
abbreviations](https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.pph7i5m5un7q).
This commit is contained in:
josh11b
2023-12-06 23:11:47 +00:00
committed by GitHub
parent fa07b52b8b
commit e9fc07feee
12 changed files with 187 additions and 229 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/handle_expr_category.cpp
+12 -16
View File
@@ -9,28 +9,27 @@ namespace Carbon::Lower {
auto HandleBindValue(FunctionContext& context, SemIR::InstId inst_id,
SemIR::BindValue inst) -> void {
switch (auto rep =
SemIR::GetValueRepresentation(context.sem_ir(), inst.type_id);
switch (auto rep = SemIR::GetValueRepr(context.sem_ir(), inst.type_id);
rep.kind) {
case SemIR::ValueRepresentation::Unknown:
case SemIR::ValueRepr::Unknown:
CARBON_FATAL()
<< "Value binding for type with incomplete value representation";
case SemIR::ValueRepresentation::None:
case SemIR::ValueRepr::None:
// Nothing should use this value, but StubRef needs a value to
// propagate.
// TODO: Remove this now the StubRefs are gone.
context.SetLocal(inst_id,
llvm::PoisonValue::get(context.GetType(inst.type_id)));
break;
case SemIR::ValueRepresentation::Copy:
case SemIR::ValueRepr::Copy:
context.SetLocal(inst_id, context.builder().CreateLoad(
context.GetType(inst.type_id),
context.GetValue(inst.value_id)));
break;
case SemIR::ValueRepresentation::Pointer:
case SemIR::ValueRepr::Pointer:
context.SetLocal(inst_id, context.GetValue(inst.value_id));
break;
case SemIR::ValueRepresentation::Custom:
case SemIR::ValueRepr::Custom:
CARBON_FATAL() << "TODO: Add support for BindValue with custom value rep";
}
}
@@ -52,9 +51,8 @@ auto HandleValueAsRef(FunctionContext& context, SemIR::InstId inst_id,
SemIR::ValueAsRef inst) -> void {
CARBON_CHECK(SemIR::GetExprCategory(context.sem_ir(), inst.value_id) ==
SemIR::ExprCategory::Value);
CARBON_CHECK(
SemIR::GetValueRepresentation(context.sem_ir(), inst.type_id).kind ==
SemIR::ValueRepresentation::Pointer);
CARBON_CHECK(SemIR::GetValueRepr(context.sem_ir(), inst.type_id).kind ==
SemIR::ValueRepr::Pointer);
context.SetLocal(inst_id, context.GetValue(inst.value_id));
}
@@ -62,12 +60,10 @@ auto HandleValueOfInitializer(FunctionContext& context, SemIR::InstId inst_id,
SemIR::ValueOfInitializer inst) -> void {
CARBON_CHECK(SemIR::GetExprCategory(context.sem_ir(), inst.init_id) ==
SemIR::ExprCategory::Initializing);
CARBON_CHECK(
SemIR::GetValueRepresentation(context.sem_ir(), inst.type_id).kind ==
SemIR::ValueRepresentation::Copy);
CARBON_CHECK(
SemIR::GetInitializingRepresentation(context.sem_ir(), inst.type_id)
.kind == SemIR::InitializingRepresentation::ByCopy);
CARBON_CHECK(SemIR::GetValueRepr(context.sem_ir(), inst.type_id).kind ==
SemIR::ValueRepr::Copy);
CARBON_CHECK(SemIR::GetInitRepr(context.sem_ir(), inst.type_id).kind ==
SemIR::InitRepr::ByCopy);
context.SetLocal(inst_id, context.GetValue(inst.init_id));
}