carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 08:14:43 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Abbreviate "representation" -> "repr" (#3464)

Browse Source 
Specifically using these abbreviations:
* InitRepr: "initializing representation"
* ObjectRepr: "object representation"
* ValueRepr: "value representation"

As discussed in [#toolchain
discord](https://discord.com/channels/655572317891461132/655578254970716160/1182086098470572143)
and now documented in the [list of
abbreviations](https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.pph7i5m5un7q).
This commit is contained in:
josh11b
2023-12-06 23:11:47 +00:00
committed by GitHub
parent fa07b52b8b
commit e9fc07feee
12 changed files with 187 additions and 229 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/handle.cpp
+10 -11
View File
@@ -144,16 +144,15 @@ auto HandleCall(FunctionContext& context, SemIR::InstId inst_id,
llvm::ArrayRef<SemIR::InstId> arg_ids =
context.sem_ir().inst_blocks().Get(inst.args_id);
if (SemIR::GetInitializingRepresentation(context.sem_ir(), inst.type_id)
.has_return_slot()) {
if (SemIR::GetInitRepr(context.sem_ir(), inst.type_id).has_return_slot()) {
args.push_back(context.GetValue(arg_ids.back()));
arg_ids = arg_ids.drop_back();
}
for (auto arg_id : arg_ids) {
auto arg_type_id = context.sem_ir().insts().Get(arg_id).type_id();
if (SemIR::GetValueRepresentation(context.sem_ir(), arg_type_id).kind !=
SemIR::ValueRepresentation::None) {
if (SemIR::GetValueRepr(context.sem_ir(), arg_type_id).kind !=
SemIR::ValueRepr::None) {
args.push_back(context.GetValue(arg_id));
}
}
@@ -256,16 +255,16 @@ auto HandleReturn(FunctionContext& context, SemIR::InstId /*inst_id*/,
auto HandleReturnExpr(FunctionContext& context, SemIR::InstId /*inst_id*/,
SemIR::ReturnExpr inst) -> void {
switch (SemIR::GetInitializingRepresentation(
context.sem_ir(),
context.sem_ir().insts().Get(inst.expr_id).type_id())
.kind) {
case SemIR::InitializingRepresentation::None:
case SemIR::InitializingRepresentation::InPlace:
switch (
SemIR::GetInitRepr(context.sem_ir(),
context.sem_ir().insts().Get(inst.expr_id).type_id())
.kind) {
case SemIR::InitRepr::None:
case SemIR::InitRepr::InPlace:
// Nothing to return.
context.builder().CreateRetVoid();
return;
case SemIR::InitializingRepresentation::ByCopy:
case SemIR::InitRepr::ByCopy:
// The expression produces the value representation for the type.
context.builder().CreateRet(context.GetValue(inst.expr_id));
return;