carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-02 22:02:51 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Update basic diagnostic capitalization/punctuation (#4328)

Browse Source 
This is a primarily automated change:

- Search & replace for capitalization
-
`(CARBON_DIAGNOSTIC\((?:\n\s+)?\w+,(?:\n\s+)?\s\w+,(?:\n\s+)?\s")([A-Z])`
    - `$1\L$2`
- Search & replace for period
-
`(CARBON_DIAGNOSTIC\((?:\n\s+)?\w+,(?:\n\s+)?\s\w+,(?:\n\s+)?\s"(?:[^)]|\n)+)\.("[,)])`
    - `$1$2`
- Limited search & replace for `ERROR: ` -> `error: ` in streamed things
- Leaving a TODO for command_line because there's more cleanup that can
be done there
- Modify diagnostic_consumer.cpp
    - ERROR -> error
    - WARNING -> warning

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
This commit is contained in:
Jon Ross-Perkins
2024-09-19 21:32:53 +00:00
committed by GitHub
co-authored by Richard Smith
parent 7f6d684b29
commit e7aebbe581
578 changed files with 2166 additions and 2173 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/handle_expr.cpp
+6 -6
View File
@@ -10,7 +10,7 @@ namespace Carbon::Parse {
static auto DiagnoseStatementOperatorAsSubExpr(Context& context) -> void {
CARBON_DIAGNOSTIC(StatementOperatorAsSubExpr, Error,
"Operator `{0}` can only be used as a complete statement.",
"operator `{0}` can only be used as a complete statement",
Lex::TokenKind);
context.emitter().Emit(*context.position(), StatementOperatorAsSubExpr,
context.PositionKind());
@@ -32,7 +32,7 @@ auto HandleExpr(Context& context) -> void {
OperatorPriority::RightFirst) {
CARBON_DIAGNOSTIC(
UnaryOperatorRequiresParentheses, Error,
"Parentheses are required around this unary `{0}` operator.",
"parentheses are required around this unary `{0}` operator",
Lex::TokenKind);
context.emitter().Emit(*context.position(),
UnaryOperatorRequiresParentheses,
@@ -182,7 +182,7 @@ auto HandleExprInPostfix(Context& context) -> void {
// OK, `.Self`.
} else {
CARBON_DIAGNOSTIC(ExpectedIdentifierOrSelfAfterPeriod, Error,
"Expected identifier or `Self` after `.`.");
"expected identifier or `Self` after `.`");
context.emitter().Emit(*context.position(),
ExpectedIdentifierOrSelfAfterPeriod);
// Only consume if it is a number or word.
@@ -211,7 +211,7 @@ auto HandleExprInPostfix(Context& context) -> void {
// Add a node to keep the parse tree balanced.
context.AddLeafNode(NodeKind::InvalidParse, *context.position(),
/*has_error=*/true);
CARBON_DIAGNOSTIC(ExpectedExpr, Error, "Expected expression.");
CARBON_DIAGNOSTIC(ExpectedExpr, Error, "expected expression");
context.emitter().Emit(*context.position(), ExpectedExpr);
context.ReturnErrorOnState();
break;
@@ -292,7 +292,7 @@ auto HandleExprLoop(Context& context) -> void {
OperatorPriority::RightFirst) {
CARBON_DIAGNOSTIC(
OperatorRequiresParentheses, Error,
"Parentheses are required to disambiguate operator precedence.");
"parentheses are required to disambiguate operator precedence");
context.emitter().Emit(*context.position(), OperatorRequiresParentheses);
} else {
// This operator wouldn't be allowed even if parenthesized.
@@ -424,7 +424,7 @@ auto HandleExprStatementFinish(Context& context) -> void {
if (!state.has_error) {
CARBON_DIAGNOSTIC(ExpectedExprSemi, Error,
"Expected `;` after expression statement.");
"expected `;` after expression statement");
context.emitter().Emit(*context.position(), ExpectedExprSemi);
}