carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Adjust handling of values in calls and structs (#2824)

Browse Source 
Previously, IR for arguments in calls and struct values was separated out. This merges it back in. Additionally, parameters for functions and struct types had their own IR; the block is still there, but there's a TODO to decide what to do with it.

In the LLVM IR, this has the consequence of emitting expressions that are inputs to a call or struct value within the scope of the function, which is pretty much where it should be. Importantly it happens before the call is encountered.

This change also tinkers with the int and real literal lowering. I'm pretty sure both are still wrong, but was having trouble figuring out a "better" way to do it, and this seems like it'll work for now.
This commit is contained in:
Jon Ross-Perkins
2023-05-18 11:42:03 -07:00
committed by GitHub
parent 4a5d925974
commit e73207429f
76 changed files with 304 additions and 518 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_handle.cpp
+11 -5
View File
@@ -79,8 +79,7 @@ auto SemanticsHandleDesignatorExpression(SemanticsContext& context,
switch (base_type.kind()) {
case SemanticsNodeKind::StructType: {
auto refs =
context.semantics().GetNodeBlock(base_type.GetAsStructType().second);
auto refs = context.semantics().GetNodeBlock(base_type.GetAsStructType());
// TODO: Do we need to optimize this with a lookup table for O(1)?
for (int i = 0; i < static_cast<int>(refs.size()); ++i) {
auto ref = context.semantics().GetNode(refs[i]);
@@ -307,14 +306,20 @@ auto SemanticsHandleNamedConstraintIntroducer(SemanticsContext& context,
auto SemanticsHandleParameterList(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto [ir_id, refs_id] = context.ParamOrArgEnd(
auto refs_id = context.ParamOrArgEnd(
/*for_args=*/false, ParseNodeKind::ParameterListStart);
// TODO: This contains the IR block for parameters. At present, it's just
// loose, but it's not strictly required for parameter refs; we should either
// stop constructing it completely or, if it turns out to be needed, store it.
// Note, the underlying issue is that the LLVM IR has nowhere clear to emit,
// so changing storage would require addressing that problem. For comparison
// with function calls, the IR needs to be emitted prior to the call.
context.node_block_stack().Pop();
context.PopScope();
context.node_stack().PopAndDiscardSoloParseNode(
ParseNodeKind::ParameterListStart);
context.finished_params_stack().push_back({ir_id, refs_id});
context.node_stack().Push(parse_node);
context.node_stack().Push(parse_node, refs_id);
return true;
}
@@ -328,6 +333,7 @@ auto SemanticsHandleParameterListStart(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
context.PushScope();
context.node_stack().Push(parse_node);
context.node_block_stack().Push();
context.ParamOrArgStart();
return true;
}