carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove ValueBinding and RefBinding (#7427)

Browse Source 
These inst kinds are now redundant with `WrapperBinding`.
This commit is contained in:
Geoff Romer
2026-06-29 17:41:23 +00:00
committed by GitHub
parent 361c832713
commit e4b0903d2e
468 changed files with 2307 additions and 2383 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/pattern.cpp
+3 -27
View File
@@ -107,38 +107,14 @@ auto AddBindingForPattern(Context& context, SemIR::LocId name_loc,
-> SemIR::InstId {
SemIR::InstKind bind_name_kind;
switch (pattern.kind) {
case SemIR::RefBindingPattern::Kind:
bind_name_kind = SemIR::RefBinding::Kind;
break;
case SemIR::SymbolicBindingPattern::Kind:
bind_name_kind = SemIR::SymbolicBinding::Kind;
break;
case SemIR::RefBindingPattern::Kind:
case SemIR::ValueBindingPattern::Kind:
bind_name_kind = SemIR::ValueBinding::Kind;
case SemIR::WrapperBindingPattern::Kind:
bind_name_kind = SemIR::WrapperBinding::Kind;
break;
case SemIR::WrapperBindingPattern::Kind: {
auto subpattern = context.insts().Get(pattern.subpattern_id);
if (subpattern.Is<SemIR::SpecificConstant>()) {
subpattern = context.constant_values().GetInst(
context.constant_values().Get(pattern.subpattern_id));
}
CARBON_KIND_SWITCH(subpattern) {
case SemIR::RefParamPattern::Kind:
case SemIR::VarPattern::Kind:
bind_name_kind = SemIR::RefBinding::Kind;
break;
case SemIR::ValueParamPattern::Kind:
bind_name_kind = SemIR::ValueBinding::Kind;
break;
case SemIR::SpliceInst::Kind:
bind_name_kind = SemIR::WrapperBinding::Kind;
break;
default:
CARBON_FATAL("Unexpected subpattern kind for at_binding_pattern: {0}",
subpattern);
}
break;
}
default:
CARBON_FATAL("pattern_kind {0} is not a binding pattern kind",
pattern.kind);