carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 07:54:41 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Explorer: Add virtual destructor support (#2695)

Browse Source 
### Features

* Add virtual `destructor`s support (Closes #2521)
* Check virtual override for virtual destructors
* Error if attempting to `Delete` a class that does not have virtual destructors from a base class pointer 

### Implementation

* Update parser to support virtual override introducers for destructors
* Check virtual override for class destructor and add to class vtable if necessary
* Add corresponding tests

### Notes

Contrary to initial implementation, this implementation leverages the `Address` structure and implements a new `Address::DowncastedAddress()` method to get address from child most class from a base class address. This avoids the need to use `GetAllocationId` and its issues when it comes to having multiple values for an `AllocationId`.

### Next work

Following this PR, we need to:

* Check when using `Delete` that the class was allocated with `New` (WIP)
* Drop the old `GetAllocationId(Value*)` in favor of a better system (WIP)
This commit is contained in:
Adrien Leravat
2023-03-22 09:58:30 -07:00
committed by GitHub
parent 782bd87316
commit df289efac4
14 changed files with 320 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/ast/declaration.h
+5 -5
View File
@@ -316,7 +316,8 @@ class DestructorDeclaration : public CallableDeclaration {
std::vector<Nonnull<AstNode*>> deduced_params,
Nonnull<TuplePattern*> param_pattern,
ReturnTerm return_term,
std::optional<Nonnull<Block*>> body)
std::optional<Nonnull<Block*>> body,
VirtualOverride virt_override)
-> ErrorOr<Nonnull<DestructorDeclaration*>>;
// Use `Create()` instead. This is public only so Arena::New() can call it.
@@ -325,12 +326,11 @@ class DestructorDeclaration : public CallableDeclaration {
std::optional<Nonnull<Pattern*>> self_pattern,
Nonnull<TuplePattern*> param_pattern,
ReturnTerm return_term,
std::optional<Nonnull<Block*>> body)
std::optional<Nonnull<Block*>> body,
VirtualOverride virt_override)
: CallableDeclaration(AstNodeKind::DestructorDeclaration, source_loc,
std::move(deduced_params), self_pattern,
param_pattern, return_term, body,
// TODO: Add virtual destructors
VirtualOverride::None) {}
param_pattern, return_term, body, virt_override) {}
explicit DestructorDeclaration(CloneContext& context,
const DestructorDeclaration& other)