carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-30 11:05:07 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Explorer: Add virtual destructor support (#2695)

Browse Source 
### Features

* Add virtual `destructor`s support (Closes #2521)
* Check virtual override for virtual destructors
* Error if attempting to `Delete` a class that does not have virtual destructors from a base class pointer 

### Implementation

* Update parser to support virtual override introducers for destructors
* Check virtual override for class destructor and add to class vtable if necessary
* Add corresponding tests

### Notes

Contrary to initial implementation, this implementation leverages the `Address` structure and implements a new `Address::DowncastedAddress()` method to get address from child most class from a base class address. This avoids the need to use `GetAllocationId` and its issues when it comes to having multiple values for an `AllocationId`.

### Next work

Following this PR, we need to:

* Check when using `Delete` that the class was allocated with `New` (WIP)
* Drop the old `GetAllocationId(Value*)` in favor of a better system (WIP)
This commit is contained in:
Adrien Leravat
2023-03-22 09:58:30 -07:00
committed by GitHub
parent 782bd87316
commit df289efac4
14 changed files with 320 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/ast/declaration.cpp
+3 -2
View File
@@ -359,14 +359,15 @@ auto DestructorDeclaration::CreateDestructor(
Nonnull<Arena*> arena, SourceLocation source_loc,
std::vector<Nonnull<AstNode*>> deduced_params,
Nonnull<TuplePattern*> param_pattern, ReturnTerm return_term,
std::optional<Nonnull<Block*>> body)
std::optional<Nonnull<Block*>> body, VirtualOverride virt_override)
-> ErrorOr<Nonnull<DestructorDeclaration*>> {
DeducedParameters split_params;
CARBON_ASSIGN_OR_RETURN(split_params,
SplitDeducedParameters(source_loc, deduced_params));
return arena->New<DestructorDeclaration>(
source_loc, std::move(split_params.resolved_params),
split_params.self_pattern, param_pattern, return_term, body);
split_params.self_pattern, param_pattern, return_term, body,
virt_override);
}
auto FunctionDeclaration::Create(Nonnull<Arena*> arena,