carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Replace FIXME with TODO in toolchain code (#4506)

Browse Source
This commit is contained in:
Geoff Romer
2024-11-08 21:10:30 +00:00
committed by GitHub
parent 5759ad8b42
commit db43bb1b42
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/file_context.cpp
+3 -3
View File
@@ -100,9 +100,9 @@ auto FileContext::BuildDICompileUnit(llvm::StringRef module_name,
llvm_module.addModuleFlag(llvm::Module::Max, "Dwarf Version", 5);
llvm_module.addModuleFlag(llvm::Module::Warning, "Debug Info Version",
llvm::DEBUG_METADATA_VERSION);
// FIXME: Include directory path in the compile_unit_file.
// TODO: Include directory path in the compile_unit_file.
llvm::DIFile* compile_unit_file = di_builder.createFile(module_name, "");
// FIXME: Introduce a new language code for Carbon. C works well for now since
// TODO: Introduce a new language code for Carbon. C works well for now since
// it's something debuggers will already know/have support for at least.
// Probably have to bump to C++ at some point for virtual functions,
// templates, etc.
@@ -447,7 +447,7 @@ auto FileContext::BuildDISubprogram(const SemIR::Function& function,
CARBON_CHECK(name, "Unexpected special name for function: {0}",
function.name_id);
auto loc = GetLocForDI(function.definition_id);
// FIXME: Add more details here, including real subroutine type (once type
// TODO: Add more details here, including real subroutine type (once type
// information is built), etc.
return di_builder_.createFunction(
di_compile_unit_, *name, llvm_function->getName(),