From d7957cc4e18c6e547e4ea39c4376b9c96c9e1da8 Mon Sep 17 00:00:00 2001 From: Kareem Ergawy Date: Mon, 15 Aug 2022 19:24:57 +0200 Subject: [PATCH] Move an llvm::Error return value instead of copying it. (#2030) Summary: Fixes a small compilation error where an llvm::Error variable was being returned by copy rather than by move. The llvm::Error copy constructor is deleted. Co-authored-by: ergawy --- toolchain/source/source_buffer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/toolchain/source/source_buffer.cpp b/toolchain/source/source_buffer.cpp index 51128d52ba17..b7dad7c8a397 100644 --- a/toolchain/source/source_buffer.cpp +++ b/toolchain/source/source_buffer.cpp @@ -36,7 +36,7 @@ auto SourceBuffer::CreateFromText(llvm::Twine text, llvm::StringRef filename) std::string buffer = text.str(); auto size_check = CheckContentSize(buffer.size()); if (size_check) { - return size_check; + return std::move(size_check); } return SourceBuffer(filename.str(), std::move(buffer)); } @@ -74,7 +74,7 @@ auto SourceBuffer::CreateFromFile(llvm::StringRef filename) } auto size_check = CheckContentSize(size); if (size_check) { - return size_check; + return std::move(size_check); } errno = 0;