carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Simplify diagnostic conversion. (#3817)

Browse Source 
Remove the enum of converted types, and use `llvm::any_cast` to
determine the type instead.
This commit is contained in:
Richard Smith
2024-03-27 18:01:28 +00:00
committed by GitHub
parent ebbc648342
commit d52ea8390a
4 changed files with 24 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/check.cpp
+7 -13
View File
@@ -72,20 +72,14 @@ class SemIRDiagnosticConverter : public DiagnosticConverter<SemIRLocation> {
}
}
auto ConvertArg(DiagnosticTypeConversion conversion, llvm::Any arg) const
-> llvm::Any override {
switch (conversion) {
case DiagnosticTypeConversion::NameId: {
auto name_id = llvm::any_cast<SemIR::NameId>(arg);
return sem_ir_->names().GetFormatted(name_id).str();
}
case DiagnosticTypeConversion::TypeId: {
auto type_id = llvm::any_cast<SemIR::TypeId>(arg);
return sem_ir_->StringifyType(type_id);
}
default:
return DiagnosticConverter<SemIRLocation>::ConvertArg(conversion, arg);
auto ConvertArg(llvm::Any arg) const -> llvm::Any override {
if (auto* name_id = llvm::any_cast<SemIR::NameId>(&arg)) {
return sem_ir_->names().GetFormatted(*name_id).str();
}
if (auto* type_id = llvm::any_cast<SemIR::TypeId>(&arg)) {
return sem_ir_->StringifyType(*type_id);
}
return DiagnosticConverter<SemIRLocation>::ConvertArg(arg);
}
private: