carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove FunctionDefinition's default constructor (#735)

Browse Source 
This opens up a path for switching `int line_num` to a `Location loc`, which I want to do for tracking filenames of code. But I don't think we should have a default constructor on `Location` to avoid mistakes, and switching FunctionDefinition to an arena alloc seems more consistent anyways.
This commit is contained in:
Jon Meow
2021-08-12 09:52:32 -07:00
committed by GitHub
parent aebfa7dac9
commit d3c7ca3131
5 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
executable_semantics/ast/declaration.h
+5 -5
View File
@@ -72,18 +72,18 @@ class Declaration {
class FunctionDeclaration : public Declaration {
public:
FunctionDeclaration(FunctionDefinition definition)
: Declaration(Kind::FunctionDeclaration, definition.line_num),
definition(std::move(definition)) {}
FunctionDeclaration(const FunctionDefinition* definition)
: Declaration(Kind::FunctionDeclaration, definition->line_num),
definition(definition) {}
static auto classof(const Declaration* decl) -> bool {
return decl->Tag() == Kind::FunctionDeclaration;
}
auto Definition() const -> const FunctionDefinition& { return definition; }
auto Definition() const -> const FunctionDefinition& { return *definition; }
private:
FunctionDefinition definition;
const FunctionDefinition* definition;
};
class StructDeclaration : public Declaration {