carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Init vptrs in Carbon initialization of Carbon-derived-from-C++ objects (#7323)

Browse Source 
For review convenience, the Clang patch is available as an LLVM Draft PR
here: https://github.com/llvm/llvm-project/pull/202807
This commit is contained in:
David Blaikie
2026-06-16 04:50:57 +00:00
committed by GitHub
parent 88b3605eac
commit cf6a89db3f
14 changed files with 402 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/convert.cpp
+10 -7
View File
@@ -544,16 +544,19 @@ static auto PerformVptrAccess(Context& context, SemIR::LocId loc_id,
if (object_repr_id == SemIR::ErrorInst::TypeId) {
return SemIR::ErrorInst::InstId;
}
if (context.types().Is<SemIR::CustomLayoutType>(object_repr_id)) {
context.TODO(loc_id, "accessing vptr of custom layout class");
return SemIR::ErrorInst::InstId;
SemIR::StructTypeFieldsId struct_type_fields_id =
SemIR::StructTypeFieldsId::None;
if (const auto& custom_layout_type =
context.types().TryGetAs<SemIR::CustomLayoutType>(object_repr_id)) {
struct_type_fields_id = custom_layout_type->fields_id;
} else {
struct_type_fields_id =
context.types().GetAs<SemIR::StructType>(object_repr_id).fields_id;
}
// Check to see if this class introduces the vptr.
auto repr_struct_type =
context.types().GetAs<SemIR::StructType>(object_repr_id);
auto repr_fields =
context.struct_type_fields().Get(repr_struct_type.fields_id);
auto repr_fields = context.struct_type_fields().Get(struct_type_fields_id);
if (auto vptr_field_index = GetVptrFieldIndex(repr_fields);
vptr_field_index.has_value()) {
return AddInst<SemIR::ClassElementAccess>(