carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add dumping for NamedConstraintId and shorten untagged id printing (#6319)

Browse Source 
Adds support to the `dump` debugger command for named constraint ids,
which are printed as `constraint<number>`. While doing so, we print
whether the `constraint` is complete or not, and add the same to
`interface` to match.

And we noticed that the printing of name and name scope ids, which are
not tagged, are very verbose by adding 7 `0`s to them for no reason. So
make the dump output easier to read by dropping 0 prefixes.

Before:
```
name_scope00000000: {inst: inst0000000E, parent_scope: name_scope<none>, has_error: false, extended_scopes: [], names: {name00000000: inst6000000F, name00000001: inst60000011}} {kind: Namespace, arg0: name_scope00000000, arg1: inst<none>, type: type(inst(NamespaceType))} `package`
```

After:
```
name_scope0: {inst: instE, parent_scope: name_scope<none>, has_error: false, extended_scopes: [], names: {name0: inst6000000F, name1: inst60000011}} {kind: Namespace, arg0: name_scope0, arg1: inst<none>, type: type(inst(NamespaceType))} `package`
```
This commit is contained in:
Dana Jansens
2025-11-05 21:36:42 +00:00
committed by GitHub
parent 99cebcf0a3
commit ce109708bf
14 changed files with 537 additions and 511 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/dump.cpp
+10 -4
View File
@@ -71,6 +71,12 @@ LLVM_DUMP_METHOD static auto Dump(const Context& context,
return SemIR::Dump(context.sem_ir(), generic_id);
}
LLVM_DUMP_METHOD static auto Dump(
const Context& context,
SemIR::IdentifiedFacetTypeId identified_facet_type_id) -> std::string {
return SemIR::Dump(context.sem_ir(), identified_facet_type_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context, SemIR::ImplId impl_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), impl_id);
@@ -109,10 +115,10 @@ LLVM_DUMP_METHOD static auto Dump(const Context& context,
return SemIR::Dump(context.sem_ir(), name_scope_id);
}
LLVM_DUMP_METHOD static auto Dump(
const Context& context,
SemIR::IdentifiedFacetTypeId identified_facet_type_id) -> std::string {
return SemIR::Dump(context.sem_ir(), identified_facet_type_id);
LLVM_DUMP_METHOD static auto Dump(const Context& context,
SemIR::NamedConstraintId named_constraint_id)
-> std::string {
return SemIR::Dump(context.sem_ir(), named_constraint_id);
}
LLVM_DUMP_METHOD static auto Dump(const Context& context,