carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 15:51:07 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Support unqualified lookup into extended interfaces from classes and impls (#7217)

Browse Source 
When a class extends an interface, referring to a member name of the
interface as an unqualified name should refer to the class's
corresponding associated entity value, not to the associated entity
itself. Similarly, in an `impl`, unqualified names of associated
entities should refer to the `impl`'s corresponding value for that
entity.

To support this, we treat `impl`s as `extend`ing their implemented facet
type, and we make lookups into an extended facet type use the `Self`
type of the extending `impl` or `class` if lookup finds an associated
entity. We already did the latter if the extending entity was an
interface; this extends the existing support for these other cases.
This commit is contained in:
Richard Smith
2026-05-19 18:01:54 +00:00
committed by GitHub
parent 0d7c4a99eb
commit ce080b3549
112 changed files with 962 additions and 4125 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/function/generic/call_method_on_generic_facet.carbon
Vendored
+2
View File
@@ -216,6 +216,7 @@ fn G() {
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .F = %ImplsGeneric.as.Generic.impl.F.decl
// CHECK:STDOUT: extend %Generic.type
// CHECK:STDOUT: witness = %Generic.impl_witness
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -226,6 +227,7 @@ fn G() {
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .G = %ImplsGeneric.as.Other.impl.G.decl
// CHECK:STDOUT: extend %Other.ref
// CHECK:STDOUT: witness = %Other.impl_witness
// CHECK:STDOUT: }
// CHECK:STDOUT:
toolchain/check/testdata/function/generic/deduce.carbon
Vendored
+3
View File
@@ -1785,6 +1785,7 @@ fn F() {
// CHECK:STDOUT: %Z.impl_witness: <witness> = impl_witness %Z.impl_witness_table [concrete = constants.%Z.impl_witness.c05]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: extend %Z.ref
// CHECK:STDOUT: witness = %Z.impl_witness
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -1800,6 +1801,7 @@ fn F() {
// CHECK:STDOUT: %Z.impl_witness.loc9_35.1: <witness> = impl_witness %Z.impl_witness_table, @DD.as.Z.impl(constants.%E) [symbolic = %Z.impl_witness.loc9_35.2 (constants.%Z.impl_witness.437)]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: extend %Z.ref
// CHECK:STDOUT: witness = %Z.impl_witness.loc9_35.1
// CHECK:STDOUT: }
// CHECK:STDOUT: }
@@ -1820,6 +1822,7 @@ fn F() {
// CHECK:STDOUT: %Z.impl_witness.loc12_39.1: <witness> = impl_witness %Z.impl_witness_table, @CC.as.Z.impl(constants.%E) [symbolic = %Z.impl_witness.loc12_39.2 (constants.%Z.impl_witness.40e)]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: extend %Z.ref
// CHECK:STDOUT: witness = %Z.impl_witness.loc12_39.1
// CHECK:STDOUT: }
// CHECK:STDOUT: }
toolchain/check/testdata/function/generic/deduce_nested_facet_value.carbon
Vendored
+3
View File
@@ -193,6 +193,7 @@ fn F() {
// CHECK:STDOUT: %Y.impl_witness: <witness> = impl_witness %Y.impl_witness_table [concrete = constants.%Y.impl_witness]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: extend %Y.ref
// CHECK:STDOUT: witness = %Y.impl_witness
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -201,6 +202,7 @@ fn F() {
// CHECK:STDOUT: %W.impl_witness: <witness> = impl_witness %W.impl_witness_table [concrete = constants.%W.impl_witness]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: extend %W.ref
// CHECK:STDOUT: witness = %W.impl_witness
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -219,6 +221,7 @@ fn F() {
// CHECK:STDOUT: %Z.impl_witness.loc19_36.1: <witness> = impl_witness %Z.impl_witness_table, @CC.as.Z.impl(constants.%E) [symbolic = %Z.impl_witness.loc19_36.2 (constants.%Z.impl_witness.228)]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: extend %Z.ref
// CHECK:STDOUT: witness = %Z.impl_witness.loc19_36.1
// CHECK:STDOUT: }
// CHECK:STDOUT: }